extensions/browser/api/cast_channel/cast_socket.h - Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket.h

Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback addressed. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/cast_channel/cast_channel_api.cc ('K') | « extensions/browser/api/cast_channel/cast_message_util.cc ('k') | extensions/browser/api/cast_channel/cast_socket.cc » ('j') | extensions/browser/api/cast_channel/cast_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_socket.h

diff --git a/extensions/browser/api/cast_channel/cast_socket.h b/extensions/browser/api/cast_channel/cast_socket.h

index bd1e377d3f8ada42ffb136dfc755aec7c6d7a054..3b443eae1f149217aa7ea8df3c2d0ca84d07544c 100644

--- a/extensions/browser/api/cast_channel/cast_socket.h

+++ b/extensions/browser/api/cast_channel/cast_socket.h

@@ -47,9 +47,11 @@ class MessageFramer;

// NOTE: Not called "CastChannel" to reduce confusion with the generated API

// code.

+// TODO(kmarshall): Inherit from CastSocket and rename to CastSocketImpl.

class CastSocket : public ApiResource {

public:

- // Object to be informed of incoming messages and errors. The CastSocket that

+ // Object to be informed of incoming messages and errors. The CastSocket

+ // that

Wez 2014/09/25 02:09:15 nit: Can be un-wrapped.

Kevin M 2014/09/25 17:53:04 Done.

// owns the delegate must not be deleted by it, only by the ApiResourceManager

// or in the callback to Close().

class Delegate {