Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.h

Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback addressed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_channel_api.h
diff --git a/extensions/browser/api/cast_channel/cast_channel_api.h b/extensions/browser/api/cast_channel/cast_channel_api.h
index ebb3173a54e97c02d9f1877b25df8fc3bf126bb9..e2ac03e8d3bf60cc6188c2d21b133d2e75385966 100644
--- a/extensions/browser/api/cast_channel/cast_channel_api.h
+++ b/extensions/browser/api/cast_channel/cast_channel_api.h
@@ -48,7 +48,8 @@ class CastChannelAPI : public BrowserContextKeyedAPI,
// BrowserContextKeyedAPI implementation.
static BrowserContextKeyedAPIFactory<CastChannelAPI>* GetFactoryInstance();
- // Returns a new CastSocket that connects to |ip_endpoint| with authentication
+ // Returns a new CastSocket that connects to |ip_endpoint| with
+ // authentication
Wez 2014/09/25 02:09:15 nit: This can be un-wrapped now that CastSocket is
Kevin M 2014/09/25 17:53:04 Done.
// |channel_auth| and is to be owned by |extension_id|.
scoped_ptr<cast_channel::CastSocket> CreateCastSocket(
const std::string& extension_id,
@@ -58,7 +59,8 @@ class CastChannelAPI : public BrowserContextKeyedAPI,
// Returns a pointer to the Logger member variable.
// TODO(imcheng): Consider whether it is possible for this class to own the
- // CastSockets and make this class the sole owner of Logger. Alternatively,
+ // CastSockets and make this class the sole owner of Logger.
+ // Alternatively,
Wez 2014/09/25 02:09:15 nit: And this!
Kevin M 2014/09/25 17:53:04 This function's still useful, the Open and GetLogs
// consider making Logger not ref-counted by passing a weak
// reference of Logger to the CastSockets instead.
scoped_refptr<cast_channel::Logger> GetLogger();

Powered by Google App Engine
This is Rietveld 408576698