extensions/browser/api/cast_channel/logger.h - Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/logger.h

Issue 555283002: Create new class "CastTransport", which encapsulates the message read and write event loops. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed wez's feedback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/cast_channel/cast_transport.cc ('K') | « extensions/browser/api/cast_channel/cast_transport_unittest.cc ('k') | extensions/browser/api/cast_channel/logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/logger.h

diff --git a/extensions/browser/api/cast_channel/logger.h b/extensions/browser/api/cast_channel/logger.h

index e7e22ac84a740ba9f573a42249c63603a6fb1be5..d9c129b7927201d3b6d967308f25da3c833a0839 100644

--- a/extensions/browser/api/cast_channel/logger.h

+++ b/extensions/browser/api/cast_channel/logger.h

@@ -42,7 +42,7 @@ class Logger : public base::RefCounted<Logger> {

// For newly created sockets. Will create an event and log a

// CAST_SOCKET_CREATED event.

- void LogNewSocketEvent(const CastSocket& cast_socket);

+ void LogNewSocketEvent(const CastSocketImpl& cast_socket);

void LogSocketEvent(int channel_id, proto::EventType event_type);

void LogSocketEventWithDetails(int channel_id,