Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc

Issue 555253005: Remove implicit conversions from scoped_refptr to T* in c/b/chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
diff --git a/chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc b/chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
index 0080355713f13c69e1250af19ef6509030a0fac9..326b9c74685fd452cd4925659ae5d34154ac2c92 100644
--- a/chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
+++ b/chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
@@ -60,9 +60,9 @@ class CertVerifyProcChromeOSTest : public testing::Test {
// The chains:
// 1. A (end-entity) -> B -> C -> D (self-signed root)
// 2. A (end-entity) -> B -> C2 -> E (self-signed root)
- ASSERT_TRUE(certs_1_[0]->Equals(certs_2_[0]));
- ASSERT_TRUE(certs_1_[1]->Equals(certs_2_[1]));
- ASSERT_FALSE(certs_1_[2]->Equals(certs_2_[2]));
+ ASSERT_TRUE(certs_1_[0]->Equals(certs_2_[0].get()));
+ ASSERT_TRUE(certs_1_[1]->Equals(certs_2_[1].get()));
+ ASSERT_FALSE(certs_1_[2]->Equals(certs_2_[2].get()));
ASSERT_EQ("C CA", certs_1_[2]->subject().common_name);
ASSERT_EQ("C CA", certs_2_[2]->subject().common_name);
@@ -167,7 +167,7 @@ TEST_F(CertVerifyProcChromeOSTest, TestChainVerify) {
EXPECT_EQ("CN=E Root CA", verify_root);
// Delete D root.
- EXPECT_TRUE(db_1_->DeleteCertAndKey(root_1_[0]));
+ EXPECT_TRUE(db_1_->DeleteCertAndKey(root_1_[0].get()));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
// User 1 should now fail to verify.
@@ -178,7 +178,7 @@ TEST_F(CertVerifyProcChromeOSTest, TestChainVerify) {
EXPECT_EQ("CN=E Root CA", verify_root);
// Delete E root.
- EXPECT_TRUE(db_2_->DeleteCertAndKey(root_2_[0]));
+ EXPECT_TRUE(db_2_->DeleteCertAndKey(root_2_[0].get()));
EXPECT_EQ(net::ERR_CERT_AUTHORITY_INVALID,
Verify(verify_proc_default_.get(), server.get(), &verify_root));
// User 1 should still fail to verify.
« no previous file with comments | « chrome/browser/chromeos/customization_wallpaper_downloader.cc ('k') | chrome/browser/chromeos/preferences.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698