chrome/browser/ui/cocoa/tabs/tab_window_controller.mm - Issue 555243002: mac: Refactor browser_window_controller layout logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

Issue 555243002: mac: Refactor browser_window_controller layout logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fullscreen_layout

Patch Set: Comments from rsesek. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_layout.h ('K') | « chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

index 6cca97080f79e08ab8343926edac80fc25e8f215..36315e0b5bf103749caf046fbdd66ff2de823bbf 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm

@@ -5,6 +5,7 @@

#import "chrome/browser/ui/cocoa/tabs/tab_window_controller.h"

#include "base/logging.h"

+#import "chrome/browser/ui/cocoa/browser_window_layout.h"

#import "chrome/browser/ui/cocoa/fast_resize_view.h"

#import "chrome/browser/ui/cocoa/framed_browser_window.h"

#import "chrome/browser/ui/cocoa/tabs/tab_strip_view.h"

@@ -64,8 +65,8 @@

NSViewHeightSizable];

[[[self window] contentView] addSubview:tabContentArea_];

- tabStripView_.reset([[TabStripView alloc] initWithFrame:

- NSMakeRect(0, 0, 750, 37)]);

+ tabStripView_.reset([[TabStripView alloc]

+ initWithFrame:NSMakeRect(0, 0, 750, mac_browser::kTabStripHeight)]);

[tabStripView_ setAutoresizingMask:NSViewWidthSizable |

NSViewMinYMargin];

if (hasTabStrip)