Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3180)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 555243002: mac: Refactor browser_window_controller layout logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fullscreen_layout
Patch Set: Comments from andresantoso, round 2. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index 5840eed7234fdca29e851e7da94a8b43af466be1..59727cb3d1d0c6448377c8f569831e394ce557ac 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -492,6 +492,8 @@ TEST_F(BrowserWindowControllerTest, TestResizeViewsWithBookmarkBar) {
// Remove the bookmark bar and recheck
profile()->GetPrefs()->SetBoolean(bookmarks::prefs::kShowBookmarkBar, false);
+ [controller_ browserWindow]->BookmarkBarStateChanged(
+ BookmarkBar::DONT_ANIMATE_STATE_CHANGE);
[controller_ resizeView:bookmark newHeight:0];
CheckViewPositions(controller_);
@@ -517,13 +519,13 @@ TEST_F(BrowserWindowControllerTest, BookmarkBarIsSameWidth) {
TEST_F(BrowserWindowControllerTest, TestTopRightForBubble) {
// The bookmark bubble must be attached to a lit and visible star.
[controller_ setStarredState:YES];
- NSPoint p = [controller_ bookmarkBubblePoint];
- NSRect all = [[controller_ window] frame];
+ NSPoint p = [controller_ bookmarkBubblePoint]; // Window coordinates.
+ NSRect all = [[controller_ window] frame]; // Screen coordinates.
// As a sanity check make sure the point is vaguely in the top right
// of the window.
- EXPECT_GT(p.y, all.origin.y + (all.size.height/2));
- EXPECT_GT(p.x, all.origin.x + (all.size.width/2));
+ EXPECT_GT(p.y, all.size.height / 2);
+ EXPECT_GT(p.x, all.size.width / 2);
}
// By the "zoom frame", we mean what Apple calls the "standard frame".

Powered by Google App Engine
This is Rietveld 408576698