Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 555223003: Add warning in documentation that the RequestContentScript action is still experimental (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add warning in documentation that the RequestContentScript action is still experimental BUG=none Committed: https://crrev.com/6559f20a72c003b1e78713062a5b19e05589016c Cr-Commit-Position: refs/heads/master@{#294040}

Patch Set 1 #

Patch Set 2 : Warning on new paragraph and in bold #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/declarative_content.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
6 years, 3 months ago (2014-09-09 22:11:44 UTC) #2
Ken Rockot(use gerrit already)
LGTM but maybe put the warning text in a new <p> block?
6 years, 3 months ago (2014-09-09 22:13:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/555223003/2
6 years, 3 months ago (2014-09-09 22:18:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:2) as 158e2673c5726dfcde3eabdc438a6e9f2fd20a9f
6 years, 3 months ago (2014-09-09 23:51:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6559f20a72c003b1e78713062a5b19e05589016c
Cr-Commit-Position: refs/heads/master@{#294040}

Powered by Google App Engine
This is Rietveld 408576698