Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 555183002: cc: Fix layer raster tile iterator not to skip a tile erroneously. (Closed)

Created:
6 years, 3 months ago by USE eero AT chromium.org
Modified:
6 years, 3 months ago
Reviewers:
reveman, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Fix layer raster tile iterator not to skip a tile erroneously. Fix the constructor of the layer raster tile iterator to never advance a tiling raster tile iterator. This fixes the iterator not to skip the first tile returned by a tiling raster tile iterator even if there are no NOW tiles but only SOON and/or EVENTUALLY tiles. Committed: https://crrev.com/2451de626227435026a3dcd83c8035baa2bf55d2 Cr-Commit-Position: refs/heads/master@{#294188}

Patch Set 1 #

Total comments: 11

Patch Set 2 : DCHECK, cleaned up unit test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M cc/layers/picture_layer_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 3 chunks +19 lines, -15 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 chunks +44 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
USE eero AT chromium.org
PTAL. Here is a fix for a layer raster tile iterator and an addition to ...
6 years, 3 months ago (2014-09-09 17:13:45 UTC) #2
vmpstr
Good catch! Thanks for fixing this. Overall looks good, I just have a few nits ...
6 years, 3 months ago (2014-09-09 17:37:35 UTC) #3
USE eero AT chromium.org
https://codereview.chromium.org/555183002/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/555183002/diff/1/cc/layers/picture_layer_impl.cc#newcode1618 cc/layers/picture_layer_impl.cc:1618: ++current_stage_; On 2014/09/09 17:37:35, vmpstr wrote: > nit: DCHECK_LT(current_stage_, ...
6 years, 3 months ago (2014-09-10 07:48:20 UTC) #4
vmpstr
lgtm https://codereview.chromium.org/555183002/diff/20001/cc/layers/picture_layer_impl_unittest.cc File cc/layers/picture_layer_impl_unittest.cc (right): https://codereview.chromium.org/555183002/diff/20001/cc/layers/picture_layer_impl_unittest.cc#newcode2576 cc/layers/picture_layer_impl_unittest.cc:2576: pending_layer_->draw_properties().visible_content_rect = This works. I just wanted it ...
6 years, 3 months ago (2014-09-10 15:49:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@samsung.com/555183002/20001
6 years, 3 months ago (2014-09-10 15:54:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (None)
6 years, 3 months ago (2014-09-10 17:31:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/e.hakkinen@samsung.com/555183002/20001
6 years, 3 months ago (2014-09-10 17:54:45 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7024d820d87bbe1f31237f8d7398bd0e93cb6635
6 years, 3 months ago (2014-09-10 18:02:26 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 18:14:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2451de626227435026a3dcd83c8035baa2bf55d2
Cr-Commit-Position: refs/heads/master@{#294188}

Powered by Google App Engine
This is Rietveld 408576698