Deactivate IDBTransactions created within Microtasks

Source/core/inspector/AsyncCallStackTracker.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/inspector/AsyncCallStackTracker.h"
 
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8RecursionScope.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/dom/ExecutionContextTask.h"
+#include "core/dom/Microtask.h"
 #include "core/events/Event.h"
 #include "core/events/EventTarget.h"
 #include "core/xml/XMLHttpRequest.h"
 #include "core/xml/XMLHttpRequestUpload.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/StringHash.h"
 #include <v8.h>
 
 namespace {
 
@@ skipping 362 matching lines @@
         return m_currentAsyncCallChain; // Propogate async call stack chain.
     }
     RefPtrWillBeRawPtr<AsyncCallChain> chain = adoptRefWillBeNoop(m_currentAsyncCallChain ? new AsyncCallStackTracker::AsyncCallChain(*m_currentAsyncCallChain) : new AsyncCallStackTracker::AsyncCallChain());
     ensureMaxAsyncCallChainDepth(chain.get(), m_maxAsyncCallStackDepth - 1);
     chain->m_callStacks.prepend(adoptRefWillBeNoop(new AsyncCallStackTracker::AsyncCallStack(description, callFrames)));
     return chain.release();
 }
 
 void AsyncCallStackTracker::setCurrentAsyncCallChain(ExecutionContext* context, PassRefPtrWillBeRawPtr<AsyncCallChain> chain)
 {
-    if (chain && !V8RecursionScope::recursionLevel(toIsolate(context))) {
+    if (chain && (!V8RecursionScope::recursionLevel(toIsolate(context)) || (V8RecursionScope::recursionLevel(toIsolate(context)) == 1 && Microtask::performingCheckpoint(toIsolate(context))))) {

[jsbell, 2014/09/22 17:26:29]

That's a lot of calls to toIsolate(context).

I could pull `v8::Isolate* isolate = toIsolate(context);` out above the if(),
but I'm not sure if this is called frequently with an empty chain and/or how
convoluted we want to make this method to maintain performance - or if that's at
all important.

[adamk, 2014/09/22 18:30:57]

I'd recommend pulling it out just to clean up the code.

[jsbell, 2014/09/22 18:49:51]

Done.

         // Current AsyncCallChain corresponds to the bottommost JS call frame.
         m_currentAsyncCallChain = chain;
         m_nestedAsyncCallCount = 1;
     } else {
         if (m_currentAsyncCallChain)
             ++m_nestedAsyncCallCount;
     }
 }
 
 void AsyncCallStackTracker::clearCurrentAsyncCallChain()
@@ skipping 35 matching lines @@
 
 void AsyncCallStackTracker::trace(Visitor* visitor)
 {
     visitor->trace(m_currentAsyncCallChain);
 #if ENABLE(OILPAN)
     visitor->trace(m_executionContextDataMap);
 #endif
 }
 
 } // namespace blink