Deactivate IDBTransactions created within Microtasks

Source/core/dom/Microtask.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/dom/Microtask.h"
 
+#include "bindings/core/v8/ModuleProxy.h"
 #include "bindings/core/v8/V8PerIsolateData.h"
+#include "bindings/core/v8/V8RecursionScope.h"
 #include "platform/Task.h"
 #include "public/platform/WebThread.h"
 #include <v8.h>
 
 namespace blink {
 
 void Microtask::performCheckpoint()
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
     V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);
     ASSERT(isolateData);
-    if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpoint())
+    if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpoint() || isolateData->destructionPending())
         return;
     isolateData->setPerformingMicrotaskCheckpoint(true);
-    isolate->RunMicrotasks();
+    {
+        // Ensure that end-of-task-or-microtask actions are performed.
+        V8RecursionScope recursionScope(isolate);
+        isolate->RunMicrotasks();
+        ModuleProxy::moduleProxy().didLeaveScriptContextForRecursionScope(isolate);

[adamk, 2014/09/22 18:30:57]

I'm not familiar with this thing. Can you explain why this isn't part of the
work V8RecursionScope does?

[jsbell, 2014/09/22 18:49:51]

Whoops, that's accidentally left in from an earlier experiment. That is what
V8RecursionScope does in its dtor, so it's completely redundant here.

+    }
     isolateData->setPerformingMicrotaskCheckpoint(false);
 }
 
+bool Microtask::performingCheckpoint(v8::Isolate* isolate)
+{
+    return V8PerIsolateData::from(isolate)->performingMicrotaskCheckpoint();
+}
+
 static void microtaskFunctionCallback(void* data)
 {
     OwnPtr<WebThread::Task> task = adoptPtr(static_cast<WebThread::Task*>(data));
     task->run();
 }
 
 void Microtask::enqueueMicrotask(PassOwnPtr<WebThread::Task> callback)
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
     isolate->EnqueueMicrotask(&microtaskFunctionCallback, callback.leakPtr());
 }
 
 void Microtask::enqueueMicrotask(const Closure& callback)
 {
     enqueueMicrotask(adoptPtr(new Task(callback)));
 }
 
 } // namespace blink