Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 555163004: Remove implicit conversion from scoped_refptr to T* in tools/gn (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversion from scoped_refptr to T* in tools/gn This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/b66e11dac00cfeb4ff097ead712dae5acfe05986 Cr-Commit-Position: refs/heads/master@{#294632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/scope.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
I'm not sure why this showed up when I ran the tool over a CrOS ...
6 years, 3 months ago (2014-09-10 21:09:36 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-12 17:13:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/555163004/1
6 years, 3 months ago (2014-09-12 17:16:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 026e4e88ca42b97b333556931166ab1c9d834735
6 years, 3 months ago (2014-09-12 19:30:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:35:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b66e11dac00cfeb4ff097ead712dae5acfe05986
Cr-Commit-Position: refs/heads/master@{#294632}

Powered by Google App Engine
This is Rietveld 408576698