Issue 555153003: Use unsigned type bitsets to limit undefined behaviour

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 555153003: Use unsigned type bitsets to limit undefined behaviour (Closed)

Created:
6 years, 3 months ago by rossberg

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Use unsigned type bitsets to limit undefined behaviour R=bmeurer@chromium.org, svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23916

Patch Set 2 : F the smi abstraction #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -137 lines)			Patch
M	src/types.h	View	1	11 chunks	+76 lines, -76 lines	0 comments	Download
M	src/types.cc	View	1	20 chunks	+59 lines, -50 lines	0 comments	Download
M	src/types-inl.h	View	1	5 chunks	+14 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

https://codereview.chromium.org/555153003/diff/1/src/types-inl.h File src/types-inl.h (right): https://codereview.chromium.org/555153003/diff/1/src/types-inl.h#newcode253 src/types-inl.h:253: return Type::cast(i::Smi::FromInt(static_cast<int>(bitset))); Use Type::cast(i::Smi::FromIntptr(bit_cast<intptr_t>(bitset))) instead.

6 years, 3 months ago (2014-09-10 04:13:24 UTC) #2

rossberg

6 years, 3 months ago (2014-09-12 13:04:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23916 (presubmit successful).

Expand Messages | Collapse Messages

Issue 555153003: Use unsigned type bitsets to limit undefined behaviour (Closed)

Description

Patch Set 1 #

Patch Set 2 : F the smi abstraction #

Messages