Source/bindings/core/v8/V8Binding.cpp - Issue 555133003: Use ExceptionState to throw exceptions when converting arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 555133003: Use ExceptionState to throw exceptions when converting arrays (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8Binding.cpp

diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp

index ad5f2f63ec914b8ba6bfc4f633beb1d21b30f796..a88dbeba5080e075d2a4046e8e71c2ea4a145066 100644

--- a/Source/bindings/core/v8/V8Binding.cpp

+++ b/Source/bindings/core/v8/V8Binding.cpp

@@ -964,7 +964,9 @@ void GetDevToolsFunctionInfo(v8::Handle<v8::Function> function, v8::Isolate* iso

scriptId = originalFunction->ScriptId();

v8::ScriptOrigin origin = originalFunction->GetScriptOrigin();

if (!origin.ResourceName().IsEmpty()) {

- resourceName = NativeValueTraits<String>::nativeValue(origin.ResourceName(), isolate);

+ V8StringResource<> stringResource(origin.ResourceName());

+ stringResource.prepare();

+ resourceName = stringResource;

lineNumber = originalFunction->GetScriptLineNumber() + 1;

}

if (resourceName.isEmpty()) {

« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »