Source/bindings/core/v8/Dictionary.h - Issue 555133003: Use ExceptionState to throw exceptions when converting arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/Dictionary.h

Issue 555133003: Use ExceptionState to throw exceptions when converting arrays (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt ('k') | Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/Dictionary.h

diff --git a/Source/bindings/core/v8/Dictionary.h b/Source/bindings/core/v8/Dictionary.h

index bfa26dcd0b50ee4015edc9d90614a62c1c4a6e8a..b9a0d5fc0914de6591081d32bb3d87914f708cde 100644

--- a/Source/bindings/core/v8/Dictionary.h

+++ b/Source/bindings/core/v8/Dictionary.h

@@ -143,7 +143,7 @@ private:

template<>

struct NativeValueTraits<Dictionary> {

- static inline Dictionary nativeValue(const v8::Handle<v8::Value>& value, v8::Isolate* isolate)

+ static inline Dictionary nativeValue(const v8::Handle<v8::Value>& value, v8::Isolate* isolate, ExceptionState&)

{

return Dictionary(value, isolate);

}