Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/core/v8/V8BindingTest.cpp

Issue 555133003: Use ExceptionState to throw exceptions when converting arrays (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8BindingTest.cpp
diff --git a/Source/bindings/core/v8/V8BindingTest.cpp b/Source/bindings/core/v8/V8BindingTest.cpp
index 8865e8cd8d8c123047b975ff777313304eb0f541..fa0d2ed88bf808e440b77c767d84d1d66c115465 100644
--- a/Source/bindings/core/v8/V8BindingTest.cpp
+++ b/Source/bindings/core/v8/V8BindingTest.cpp
@@ -305,7 +305,8 @@ TEST_F(V8ValueTraitsTest, toImplArray)
v8StringArray->Set(toV8Value(0), toV8Value("Hello, World!"));
v8StringArray->Set(toV8Value(1), toV8Value("Hi, Mom!"));
- Vector<String> stringVector = toImplArray<String>(v8StringArray, 0, m_scope.isolate());
+ NonThrowableExceptionState exceptionState;
+ Vector<String> stringVector = toImplArray<String>(v8StringArray, 0, m_scope.isolate(), exceptionState);
EXPECT_EQ(2U, stringVector.size());
EXPECT_EQ("Hello, World!", stringVector[0]);
EXPECT_EQ("Hi, Mom!", stringVector[1]);
@@ -316,7 +317,8 @@ TEST_F(V8ValueTraitsTest, toImplArray)
v8UnsignedArray->Set(toV8Value(1), toV8Value(1729));
v8UnsignedArray->Set(toV8Value(2), toV8Value(31773));
- Vector<unsigned> unsignedVector = toImplArray<unsigned>(v8UnsignedArray, 0, m_scope.isolate());
+ NonThrowableExceptionState exceptionState;
+ Vector<unsigned> unsignedVector = toImplArray<unsigned>(v8UnsignedArray, 0, m_scope.isolate(), exceptionState);
EXPECT_EQ(3U, unsignedVector.size());
EXPECT_EQ(42U, unsignedVector[0]);
EXPECT_EQ(1729U, unsignedVector[1]);
@@ -328,11 +330,12 @@ TEST_F(V8ValueTraitsTest, toImplArray)
v8::Handle<v8::Array> v8RealArray = v8::Array::New(m_scope.isolate(), 1);
v8RealArray->Set(toV8Value(0), toV8Value(doublePi));
- Vector<double> doubleVector = toImplArray<double>(v8RealArray, 0, m_scope.isolate());
+ NonThrowableExceptionState exceptionState;
+ Vector<double> doubleVector = toImplArray<double>(v8RealArray, 0, m_scope.isolate(), exceptionState);
EXPECT_EQ(1U, doubleVector.size());
EXPECT_EQ(doublePi, doubleVector[0]);
- Vector<float> floatVector = toImplArray<float>(v8RealArray, 0, m_scope.isolate());
+ Vector<float> floatVector = toImplArray<float>(v8RealArray, 0, m_scope.isolate(), exceptionState);
EXPECT_EQ(1U, floatVector.size());
EXPECT_EQ(floatPi, floatVector[0]);
}
@@ -342,14 +345,14 @@ TEST_F(V8ValueTraitsTest, toImplArray)
v8Array->Set(toV8Value(1), toV8Value(65535));
v8Array->Set(toV8Value(2), toV8Value(0.125));
- Vector<v8::Handle<v8::Value> > v8HandleVector = toImplArray<v8::Handle<v8::Value> >(v8Array, 0, m_scope.isolate());
- EXPECT_EQ(3U, v8HandleVector.size());
NonThrowableExceptionState exceptionState;
+ Vector<v8::Handle<v8::Value> > v8HandleVector = toImplArray<v8::Handle<v8::Value> >(v8Array, 0, m_scope.isolate(), exceptionState);
+ EXPECT_EQ(3U, v8HandleVector.size());
EXPECT_EQ("Vini, vidi, vici.", toScalarValueString(v8HandleVector[0], exceptionState));
EXPECT_EQ(65535U, toUInt32(v8HandleVector[1]));
EXPECT_EQ(0.125, toFloat(v8HandleVector[2]));
- Vector<ScriptValue> scriptValueVector = toImplArray<ScriptValue>(v8Array, 0, m_scope.isolate());
+ Vector<ScriptValue> scriptValueVector = toImplArray<ScriptValue>(v8Array, 0, m_scope.isolate(), exceptionState);
EXPECT_EQ(3U, scriptValueVector.size());
String reportOnZela;
EXPECT_TRUE(scriptValueVector[0].toString(reportOnZela));

Powered by Google App Engine
This is Rietveld 408576698