Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/bindings/templates/methods.cpp

Issue 555133003: Use ExceptionState to throw exceptions when converting arrays (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix toV8Sequence() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {##############################################################################} 1 {##############################################################################}
2 {% macro generate_method(method, world_suffix) %} 2 {% macro generate_method(method, world_suffix) %}
3 {% filter conditional(method.conditional_string) %} 3 {% filter conditional(method.conditional_string) %}
4 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info) 4 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
5 { 5 {
6 {# Local variables #} 6 {# Local variables #}
7 {% if method.has_exception_state %} 7 {% if method.has_exception_state %}
8 ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.na me}}", "{{interface_name}}", info.Holder(), info.GetIsolate()); 8 ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.na me}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
9 {% endif %} 9 {% endif %}
10 {# Overloaded methods have length checked during overload resolution #} 10 {# Overloaded methods have length checked during overload resolution #}
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 {% endif %} 436 {% endif %}
437 {% endif %}{# not method.overloads #} 437 {% endif %}{# not method.overloads #}
438 {% if world_suffix in method.activity_logging_world_list %} 438 {% if world_suffix in method.activity_logging_world_list %}
439 ScriptState* scriptState = ScriptState::from(info.GetIsolate()->GetCurrentCo ntext()); 439 ScriptState* scriptState = ScriptState::from(info.GetIsolate()->GetCurrentCo ntext());
440 V8PerContextData* contextData = scriptState->perContextData(); 440 V8PerContextData* contextData = scriptState->perContextData();
441 {% if method.activity_logging_world_check %} 441 {% if method.activity_logging_world_check %}
442 if (scriptState->world().isIsolatedWorld() && contextData && contextData->ac tivityLogger()) 442 if (scriptState->world().isIsolatedWorld() && contextData && contextData->ac tivityLogger())
443 {% else %} 443 {% else %}
444 if (contextData && contextData->activityLogger()) { 444 if (contextData && contextData->activityLogger()) {
445 {% endif %} 445 {% endif %}
446 Vector<v8::Handle<v8::Value> > loggerArgs = toImplArguments<v8::Handle<v 8::Value> >(info, 0); 446 ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{metho d.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
447 Vector<v8::Handle<v8::Value> > loggerArgs = toImplArguments<v8::Handle<v 8::Value> >(info, 0, exceptionState);
447 contextData->activityLogger()->logMethod("{{interface_name}}.{{method.na me}}", info.Length(), loggerArgs.data()); 448 contextData->activityLogger()->logMethod("{{interface_name}}.{{method.na me}}", info.Length(), loggerArgs.data());
448 } 449 }
449 {% endif %} 450 {% endif %}
450 {% if method.is_custom %} 451 {% if method.is_custom %}
451 {{v8_class}}::{{method.name}}MethodCustom(info); 452 {{v8_class}}::{{method.name}}MethodCustom(info);
452 {% else %} 453 {% else %}
453 {{cpp_class}}V8Internal::{{method.name}}Method{{world_suffix}}(info); 454 {{cpp_class}}V8Internal::{{method.name}}Method{{world_suffix}}(info);
454 {% endif %} 455 {% endif %}
455 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 456 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
456 } 457 }
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
630 if method.is_per_world_bindings else '0' %} 631 if method.is_per_world_bindings else '0' %}
631 {% set property_attribute = 632 {% set property_attribute =
632 'static_cast<v8::PropertyAttribute>(%s)' % ' | '.join(method.property_attribut es) 633 'static_cast<v8::PropertyAttribute>(%s)' % ' | '.join(method.property_attribut es)
633 if method.property_attributes else 'v8::None' %} 634 if method.property_attributes else 'v8::None' %}
634 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %} 635 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %}
635 static const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfig uration = { 636 static const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfig uration = {
636 "{{method.name}}", {{method_callback}}, {{method_callback_for_main_world}}, {{method.length}}, {{only_exposed_to_private_script}}, 637 "{{method.name}}", {{method_callback}}, {{method_callback_for_main_world}}, {{method.length}}, {{only_exposed_to_private_script}},
637 }; 638 };
638 V8DOMConfiguration::installMethod({{method.function_template}}, {{method.signatu re}}, {{property_attribute}}, {{method.name}}MethodConfiguration, isolate); 639 V8DOMConfiguration::installMethod({{method.function_template}}, {{method.signatu re}}, {{property_attribute}}, {{method.name}}MethodConfiguration, isolate);
639 {%- endmacro %} 640 {%- endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698