Use ExceptionState to throw exceptions when converting arrays

Source/bindings/scripts/v8_methods.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 45 matching lines @@
     return_promise = method.idl_type and method.idl_type.name == 'Promise'
     idl_type = argument.idl_type
     base_type = idl_type.base_type
 
     return not(
         # These cases are handled by separate code paths in the
         # generate_argument() macro in Source/bindings/templates/methods.cpp.
         idl_type.is_callback_interface or
         base_type == 'SerializedScriptValue' or
         (argument.is_variadic and idl_type.is_wrapper_type) or
+        # Variadic arguments use toImplArguments() with throws excentions via
+        # its ExceptionState& argument.
+        argument.is_variadic or
         # String and enumeration arguments converted using one of the
         # TOSTRING_* macros except for _PROMISE variants in
         # Source/bindings/core/v8/V8BindingMacros.h don't use a v8::TryCatch.
         ((base_type == 'DOMString' or idl_type.is_enum) and
-         not argument.is_variadic and
          not return_promise) or
         # Conversion that take an ExceptionState& argument throw all their
         # exceptions via it, and doesn't need/use a TryCatch, except if the
         # argument has [Clamp], in which case it uses a separate code path in
         # Source/bindings/templates/methods.cpp, which *does* use a TryCatch.
-        idl_type.v8_conversion_needs_exception_state or
+        argument.v8_conversion_needs_exception_state or
         # A trivial conversion cannot throw exceptions at all, so doesn't need a
         # TryCatch to catch them.
         idl_type.v8_conversion_is_trivial)
 
 
 def use_local_result(method):
     extended_attributes = method.extended_attributes
     idl_type = method.idl_type
     return (has_extended_attribute_value(method, 'CallWith', 'ScriptState') or
             'ImplementedInPrivateScript' in extended_attributes or
@@ skipping 77 matching lines @@
         'exposed_test': v8_utilities.exposed(method, interface),  # [Exposed]
         'function_template': function_template(),
         'has_custom_registration': is_static or
             v8_utilities.has_extended_attribute(
                 method, CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES),
         'has_exception_state':
             is_raises_exception or
             is_check_security_for_frame or
             is_check_security_for_window or
             any(argument for argument in arguments
-                if argument.idl_type.name == 'SerializedScriptValue' or
-                   argument.idl_type.v8_conversion_needs_exception_state),
+                if (argument.idl_type.name == 'SerializedScriptValue' or
+                    argument.v8_conversion_needs_exception_state)),
         'idl_type': idl_type.base_type,
         'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),
         'is_call_with_script_arguments': is_call_with_script_arguments,
         'is_call_with_script_state': is_call_with_script_state,
         'is_check_security_for_frame': is_check_security_for_frame,
         'is_check_security_for_node': is_check_security_for_node,
         'is_check_security_for_window': is_check_security_for_window,
         'is_custom': 'Custom' in extended_attributes,
         'is_custom_element_callbacks': is_custom_element_callbacks,
         'is_do_not_check_security': is_do_not_check_security,
@@ skipping 188 matching lines @@
     script_wrappable = 'impl' if inherits_interface(interface_name, 'Node') else ''
     return idl_type.v8_set_return_value(cpp_value, extended_attributes, script_wrappable=script_wrappable, release=release, for_main_world=for_main_world)
 
 
 def v8_value_to_local_cpp_variadic_value(argument, index, return_promise):
     assert argument.is_variadic
     idl_type = argument.idl_type
 
     suffix = ''
 
-    macro = 'TONATIVE_VOID'
+    macro = 'TONATIVE_VOID_EXCEPTIONSTATE'
     macro_args = [
-      argument.name,
-      'toImplArguments<%s>(info, %s)' % (idl_type.cpp_type, index),
+        argument.name,
+        'toImplArguments<%s>(info, %s, exceptionState)' % (idl_type.cpp_type, index),
+        'exceptionState',
     ]
 
     if return_promise:
         suffix += '_PROMISE'
-        macro_args.append('info')
+        macro_args.extend(['info', 'ScriptState::current(info.GetIsolate())'])
 
     suffix += '_INTERNAL'
 
     return '%s%s(%s)' % (macro, suffix, ', '.join(macro_args))
 
 
 def v8_value_to_local_cpp_value(argument, index, return_promise=False):
     extended_attributes = argument.extended_attributes
     idl_type = argument.idl_type
     name = argument.name
@@ skipping 58 matching lines @@
     if argument.idl_type.is_dictionary:
         # We always create impl objects for IDL dictionaries.
         return '%s::create()' % argument.idl_type.base_type
     if not argument.default_value:
         return None
     return argument.idl_type.literal_cpp_value(argument.default_value)
 
 IdlTypeBase.union_arguments = None
 IdlUnionType.union_arguments = property(union_arguments)
 IdlArgument.default_cpp_value = property(argument_default_cpp_value)
+
+
+def v8_conversion_needs_exception_state(argument):
+    return (argument.idl_type.v8_conversion_needs_exception_state or
+            argument.is_variadic)
+
+IdlArgument.v8_conversion_needs_exception_state = property(v8_conversion_needs_exception_state)