Use ExceptionState to throw exceptions when converting arrays

Source/bindings/core/v8/custom/V8WebGLRenderingContextCustom.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 521 matching lines @@
     if (info[indexArrayArgument].IsEmpty() || !info[indexArrayArgument]->IsArray()) {
         exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(indexArrayArgument + 1, "Array"));
         exceptionState.throwIfNeeded();
         return;
     }
     v8::Handle<v8::Array> array = v8::Local<v8::Array>::Cast(info[1]);
     if (array->Length() > WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(float)) {
         exceptionState.throwTypeError("Array length exceeds supported limit.");
         return;
     }
-    v8::TryCatch block;
-    Vector<float> implArray = toImplArray<float>(array, 0, info.GetIsolate());
-    if (block.HasCaught()) {
-        block.ReThrow();
+    Vector<float> implArray = toImplArray<float>(array, 0, info.GetIsolate(), exceptionState);
+    if (exceptionState.hadException())
         return;
-    }
     switch (functionToCall) {
     case kUniform1v: context->uniform1fv(location, implArray.data(), implArray.size()); break;
     case kUniform2v: context->uniform2fv(location, implArray.data(), implArray.size()); break;
     case kUniform3v: context->uniform3fv(location, implArray.data(), implArray.size()); break;
     case kUniform4v: context->uniform4fv(location, implArray.data(), implArray.size()); break;
     case kVertexAttrib1v: context->vertexAttrib1fv(index, implArray.data(), implArray.size()); break;
     case kVertexAttrib2v: context->vertexAttrib2fv(index, implArray.data(), implArray.size()); break;
     case kVertexAttrib3v: context->vertexAttrib3fv(index, implArray.data(), implArray.size()); break;
     case kVertexAttrib4v: context->vertexAttrib4fv(index, implArray.data(), implArray.size()); break;
     default: ASSERT_NOT_REACHED(); break;
@@ skipping 44 matching lines @@
     if (info[indexArrayArgumentIndex].IsEmpty() || !info[indexArrayArgumentIndex]->IsArray()) {
         exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(indexArrayArgumentIndex + 1, "Array"));
         exceptionState.throwIfNeeded();
         return;
     }
     v8::Handle<v8::Array> array = v8::Local<v8::Array>::Cast(info[indexArrayArgumentIndex]);
     if (array->Length() >  WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(int)) {
         exceptionState.throwTypeError("Array length exceeds supported limit.");
         return;
     }
-    v8::TryCatch block;
-    Vector<int> implArray = toImplArray<int>(array, 0, info.GetIsolate());
-    if (block.HasCaught()) {
-        block.ReThrow();
+    Vector<int> implArray = toImplArray<int>(array, 0, info.GetIsolate(), exceptionState);
+    if (exceptionState.hadException())
         return;
-    }
     switch (functionToCall) {
     case kUniform1v: context->uniform1iv(location, implArray.data(), implArray.size()); break;
     case kUniform2v: context->uniform2iv(location, implArray.data(), implArray.size()); break;
     case kUniform3v: context->uniform3iv(location, implArray.data(), implArray.size()); break;
     case kUniform4v: context->uniform4iv(location, implArray.data(), implArray.size()); break;
     default: ASSERT_NOT_REACHED(); break;
     }
 }
 
 void V8WebGLRenderingContext::uniform1fvMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ skipping 88 matching lines @@
     if (info[arrayArgumentIndex].IsEmpty() || !info[arrayArgumentIndex]->IsArray()) {
         exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(arrayArgumentIndex + 1, "Array"));
         exceptionState.throwIfNeeded();
         return;
     }
     v8::Handle<v8::Array> array = v8::Local<v8::Array>::Cast(info[2]);
     if (array->Length() >  WTF::DefaultAllocatorQuantizer::kMaxUnquantizedAllocation / sizeof(float)) {
         exceptionState.throwTypeError("Array length exceeds supported limit.");
         return;
     }
-    v8::TryCatch block;
-    Vector<float> implArray = toImplArray<float>(array, 0, info.GetIsolate());
-    if (block.HasCaught()) {
-        block.ReThrow();
+    Vector<float> implArray = toImplArray<float>(array, 0, info.GetIsolate(), exceptionState);
+    if (exceptionState.hadException())
         return;
-    }
     switch (matrixSize) {
     case 2: context->uniformMatrix2fv(location, transpose, implArray.data(), implArray.size()); break;
     case 3: context->uniformMatrix3fv(location, transpose, implArray.data(), implArray.size()); break;
     case 4: context->uniformMatrix4fv(location, transpose, implArray.data(), implArray.size()); break;
     default: ASSERT_NOT_REACHED(); break;
     }
 }
 
 void V8WebGLRenderingContext::uniformMatrix2fvMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
@@ skipping 31 matching lines @@
     vertexAttribAndUniformHelperf(info, kVertexAttrib3v, exceptionState);
 }
 
 void V8WebGLRenderingContext::vertexAttrib4fvMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "vertexAttrib4fv", "WebGLRenderingContext", info.Holder(), info.GetIsolate());
     vertexAttribAndUniformHelperf(info, kVertexAttrib4v, exceptionState);
 }
 
 } // namespace blink