Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/bindings/templates/methods.cpp

Issue 555133003: Use ExceptionState to throw exceptions when converting arrays (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {##############################################################################} 1 {##############################################################################}
2 {% macro generate_method(method, world_suffix) %} 2 {% macro generate_method(method, world_suffix) %}
3 {% filter conditional(method.conditional_string) %} 3 {% filter conditional(method.conditional_string) %}
4 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info) 4 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
5 { 5 {
6 {# Local variables #} 6 {# Local variables #}
7 {% if method.has_exception_state %} 7 {% if method.has_exception_state %}
8 ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.na me}}", "{{interface_name}}", info.Holder(), info.GetIsolate()); 8 ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.na me}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
9 {% endif %} 9 {% endif %}
10 {# Overloaded methods have length checked during overload resolution #} 10 {# Overloaded methods have length checked during overload resolution #}
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 {% endif %} 451 {% endif %}
452 {% endif %}{# not method.overloads #} 452 {% endif %}{# not method.overloads #}
453 {% if world_suffix in method.activity_logging_world_list %} 453 {% if world_suffix in method.activity_logging_world_list %}
454 ScriptState* scriptState = ScriptState::from(info.GetIsolate()->GetCurrentCo ntext()); 454 ScriptState* scriptState = ScriptState::from(info.GetIsolate()->GetCurrentCo ntext());
455 V8PerContextData* contextData = scriptState->perContextData(); 455 V8PerContextData* contextData = scriptState->perContextData();
456 {% if method.activity_logging_world_check %} 456 {% if method.activity_logging_world_check %}
457 if (scriptState->world().isIsolatedWorld() && contextData && contextData->ac tivityLogger()) 457 if (scriptState->world().isIsolatedWorld() && contextData && contextData->ac tivityLogger())
458 {% else %} 458 {% else %}
459 if (contextData && contextData->activityLogger()) { 459 if (contextData && contextData->activityLogger()) {
460 {% endif %} 460 {% endif %}
461 Vector<v8::Handle<v8::Value> > loggerArgs = toImplArguments<v8::Handle<v 8::Value> >(info, 0); 461 ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{metho d.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
462 Vector<v8::Handle<v8::Value> > loggerArgs = toImplArguments<v8::Handle<v 8::Value> >(info, 0, exceptionState);
462 contextData->activityLogger()->logMethod("{{interface_name}}.{{method.na me}}", info.Length(), loggerArgs.data()); 463 contextData->activityLogger()->logMethod("{{interface_name}}.{{method.na me}}", info.Length(), loggerArgs.data());
463 } 464 }
464 {% endif %} 465 {% endif %}
465 {% if method.is_custom %} 466 {% if method.is_custom %}
466 {{v8_class}}::{{method.name}}MethodCustom(info); 467 {{v8_class}}::{{method.name}}MethodCustom(info);
467 {% else %} 468 {% else %}
468 {{cpp_class}}V8Internal::{{method.name}}Method{{world_suffix}}(info); 469 {{cpp_class}}V8Internal::{{method.name}}Method{{world_suffix}}(info);
469 {% endif %} 470 {% endif %}
470 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 471 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
471 } 472 }
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 if method.is_per_world_bindings else '0' %} 646 if method.is_per_world_bindings else '0' %}
646 {% set property_attribute = 647 {% set property_attribute =
647 'static_cast<v8::PropertyAttribute>(%s)' % ' | '.join(method.property_attribut es) 648 'static_cast<v8::PropertyAttribute>(%s)' % ' | '.join(method.property_attribut es)
648 if method.property_attributes else 'v8::None' %} 649 if method.property_attributes else 'v8::None' %}
649 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %} 650 {% set only_exposed_to_private_script = 'V8DOMConfiguration::OnlyExposedToPrivat eScript' if method.only_exposed_to_private_script else 'V8DOMConfiguration::Expo sedToAllScripts' %}
650 static const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfig uration = { 651 static const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfig uration = {
651 "{{method.name}}", {{method_callback}}, {{method_callback_for_main_world}}, {{method.length}}, {{only_exposed_to_private_script}}, 652 "{{method.name}}", {{method_callback}}, {{method_callback_for_main_world}}, {{method.length}}, {{only_exposed_to_private_script}},
652 }; 653 };
653 V8DOMConfiguration::installMethod({{method.function_template}}, {{method.signatu re}}, {{property_attribute}}, {{method.name}}MethodConfiguration, isolate); 654 V8DOMConfiguration::installMethod({{method.function_template}}, {{method.signatu re}}, {{property_attribute}}, {{method.name}}MethodConfiguration, isolate);
654 {%- endmacro %} 655 {%- endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698