Use ExceptionState to throw exceptions when converting arrays

Source/bindings/core/v8/DictionaryHelperForCore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 257 matching lines @@
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, MessagePortArray& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
     ASSERT(dictionary.isolate());
     ASSERT(dictionary.isolate() == v8::Isolate::GetCurrent());
     if (blink::isUndefinedOrNull(v8Value))
         return true;
-    bool success = false;
-    value = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(v8Value, key, dictionary.isolate(), &success);
-    return success;
+    // FIXME (before landing): We can't use a NonThrowableExceptionState here; figure out what to do instead.

[Jens Widell, 2014/09/11 13:22:31]

Need to resolve this. I thought I couldn't create a full ExceptionState here,
but maybe I can, using dictionary.v8value() for the |creationContext| argument?

Otherwise passing in an ExceptionState& to this method would be the natural
approach, I guess, but that will expand the patch even more, and I wasn't sure
if we really wanted to spend too much effort on Dictionary/DictionaryHelper at
this point.

+    NonThrowableExceptionState exceptionState;
+    value = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(v8Value, key, dictionary.isolate(), exceptionState);
+    return !exceptionState.throwIfNeeded();
 }
 
 template <>
 bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, HashSet<AtomicString>& value)
 {
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return false;
 
     // FIXME: Support array-like objects
@@ skipping 362 matching lines @@
     Dictionary::ConversionContextScope scope(context);
 
     v8::Local<v8::Value> v8Value;
     if (!dictionary.get(key, v8Value))
         return true;
 
     return DictionaryHelper::get(dictionary, key, value);
 }
 
 } // namespace blink