Add ResourceType::PING. and mark those requests as detachable.

Add ResourceType::PING and mark those requests as detachable.

This avoids cancelling <a ping> requests on cross-process navigations
when the owning renderer dies.

Actually assigning resources this type is conditioned on a currently
undefined WEBKIT_HAS_TARGET_PING symbol to be defined in a follow-up
Blink CL. The #ifdef can then be removed when that lands.

BUG=302816
TEST=ResourceDispatcherHostTest.DeletedFilterDetachable

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236807

[davidben, 2013-10-31 23:02:22]

To be followed by https://codereview.chromium.org/55203003/ in Blink.

Plan, patterned after how ResourceType::XHR was added.
1. Land this CL.
2. Land https://codereview.chromium.org/55203003/
--- wait for Blink roll ---
3. Chromium CL to remove the #ifdef and hook ResourceType::PING to the machinery
added for ResourceType::PREFETCH. Everything works.
4. Blink CL to remove the #define.

[davidben, 2013-11-01 15:43:29]

+asvitkine for histograms.xml change.

[Alexei Svitkine (slow), 2013-11-01 15:49:30]

LGTM with a comment

https://codereview.chromium.org/55513002/diff/80001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/55513002/diff/80001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:27113: +  <int value="15"
label="LAST_TYPE"/>
"LAST_TYPE" is not a valid enum value that can be reported by the client, as far
as I understand it. If so, please remove it from this list.

[davidben, 2013-11-01 15:59:28]

https://codereview.chromium.org/55513002/diff/80001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/55513002/diff/80001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:27113: +  <int value="15"
label="LAST_TYPE"/>
On 2013/11/01 15:49:30, Alexei Svitkine wrote:
> "LAST_TYPE" is not a valid enum value that can be reported by the client, as
far
> as I understand it. If so, please remove it from this list.

Done.

[davidben, 2013-11-01 19:28:12]

I suppose there's no reason why I can't hook this up to the RDHI in this CL.

+simonjam for content/browser/loader.

[James Simonsen, 2013-11-01 21:04:51]

lgtm

[jamesr, 2013-11-04 19:19:17]

lgtm

[mmenke, 2013-11-21 15:28:45]

The rebase LGTM

https://codereview.chromium.org/55513002/diff/270001/content/browser/loader/r...
File content/browser/loader/resource_dispatcher_host_unittest.cc (right):

https://codereview.chromium.org/55513002/diff/270001/content/browser/loader/r...
content/browser/loader/resource_dispatcher_host_unittest.cc:1043:
DCHECK(info_ping->filter() == filter_.get());
nit:  DCHECK_EQ?

[davidben, 2013-11-22 16:03:47]

https://codereview.chromium.org/55513002/diff/270001/content/browser/loader/r...
File content/browser/loader/resource_dispatcher_host_unittest.cc (right):

https://codereview.chromium.org/55513002/diff/270001/content/browser/loader/r...
content/browser/loader/resource_dispatcher_host_unittest.cc:1043:
DCHECK(info_ping->filter() == filter_.get());
On 2013/11/21 15:28:45, mmenke wrote:
> nit:  DCHECK_EQ?

Done.

[commit-bot: I haz the power, 2013-11-22 16:04:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidben@chromium.org/55513002/400001

[commit-bot: I haz the power, 2013-11-22 19:24:47]

Change committed as 236807