Filter abstract classes when computing candidate classes for custom elements.

tests/html/custom/document_register_basic_test.dart

Index: tests/html/custom/document_register_basic_test.dart
diff --git a/tests/html/custom/document_register_basic_test.dart b/tests/html/custom/document_register_basic_test.dart
index e127ebf648d526adaae8c38b4688aa900920af6b..cf11b6373de8cdda251fcca254c34c98d7e3fb0d 100644
--- a/tests/html/custom/document_register_basic_test.dart
+++ b/tests/html/custom/document_register_basic_test.dart
@@ -35,9 +35,13 @@ class Baz extends Foo {
 class BadB {
 }
 
-class BadE implements HtmlElement {
-  static final tag = 'x-tag-e';
-  factory BadE() => new Element.tag(tag);
+abstract class BadC extends HtmlElement {
+  BadC.created() : super.created();
+}
+
+class BadF implements HtmlElement {
+  static final tag = 'x-tag-f';
+  factory BadF() => new Element.tag(tag);
 }
 
 main() {
@@ -56,14 +60,17 @@ main() {
     // Invalid user type.  Doesn't inherit from HtmlElement.
     expect(() => document.registerElement('x-bad-b', BadB), throws);
 
+    // Cannot register abstract class.
+    expect(() => document.registerElement('x-bad-c', BadC), throws);

[karlklose, 2014/09/09 13:02:22]

You could make this a multitest with label OK and add a comment to the status
file to remove the label when fixing the bug.

[herhut, 2014/09/09 13:33:26]

Just for the record: It seems this is not supported.

+
     // Not a type.
-    expect(() => document.registerElement('x-bad-c', null), throws);
+    expect(() => document.registerElement('x-bad-d', null), throws);
 
     // Cannot register system type.
-    expect(() => document.registerElement('x-bad-d', Object), throws);
+    expect(() => document.registerElement('x-bad-e', Object), throws);
 
     // Must extend HtmlElement, not just implement it.
-    expect(() => document.registerElement(BadE.tag, BadE), throws);
+    expect(() => document.registerElement(BadF.tag, BadF), throws);
 
     // Constructor initiated instantiation
     var createdFoo = new Foo();