sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart - Issue 555123002: Filter abstract classes when computing candidate classes for custom elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

Issue 555123002: Filter abstract classes when computing candidate classes for custom elements. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart b/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

index 695edbb19dd102a6f8448f608e43f7da686cb229..ade211ddbe654163898b5bd17ebf8f0c732845bc 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/custom_elements_analysis.dart

@@ -70,6 +70,7 @@ class CustomElementsAnalysis {

classElement.ensureResolved(compiler);

if (!Elements.isNativeOrExtendsNative(classElement)) return;

if (classElement.isMixinApplication) return;

+ if (classElement.isAbstract) return;

joinFor(enqueuer).instantiatedClasses.add(classElement);

}

« no previous file with comments | « no previous file | tests/html/custom/document_register_basic_test.dart » ('j') | tests/html/custom/document_register_basic_test.dart » ('J')