Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 555113002: Android video capture: suppress deprecated warnings while migrating to new API (Closed)

Created:
6 years, 3 months ago by magjed_chromium
Modified:
6 years, 3 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android video capture: suppress deprecated warnings while migrating to new API Suppress most deprecated warnings except for imports. BUG=398669 Committed: https://crrev.com/dfdafaea26ecfb790390a0513b91f2832904b5d5 Cr-Commit-Position: refs/heads/master@{#293968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCapture.java View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureTango.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
magjed_chromium
PTAL
6 years, 3 months ago (2014-09-09 12:03:18 UTC) #2
henrika (OOO until Aug 14)
FYI; I am not an owner and can't give OK. It looks OK. How many ...
6 years, 3 months ago (2014-09-09 12:06:00 UTC) #3
mcasas
aurimas@ can you take a look? qinmin@ RS OWNERS -- you're the last man standing!
6 years, 3 months ago (2014-09-09 12:41:31 UTC) #5
magjed_chromium
The number of warnings in video capture is reduced from 79 to 11. It might ...
6 years, 3 months ago (2014-09-09 12:52:41 UTC) #6
aurimas (slooooooooow)
LGTM as long you add a todo to actually fix these warnings once final Android ...
6 years, 3 months ago (2014-09-09 15:23:35 UTC) #7
qinmin
lgtm
6 years, 3 months ago (2014-09-09 16:46:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/magjed@chromium.org/555113002/1
6 years, 3 months ago (2014-09-09 16:53:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 69bc2ae9dace5e2e7f48302f8fea48728927d195
6 years, 3 months ago (2014-09-09 18:14:48 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfdafaea26ecfb790390a0513b91f2832904b5d5
Cr-Commit-Position: refs/heads/master@{#293968}

Powered by Google App Engine
This is Rietveld 408576698