Fix WeakPtrFactory ordering problems in src/tools

tools/android/forwarder2/device_controller.h

Index: tools/android/forwarder2/device_controller.h
diff --git a/tools/android/forwarder2/device_controller.h b/tools/android/forwarder2/device_controller.h
index b1441d81a789c18fba3dc22f8a0224859c63f571..a802af426349216f37525c3d3d67bbd1546a025b 100644
--- a/tools/android/forwarder2/device_controller.h
+++ b/tools/android/forwarder2/device_controller.h
@@ -49,7 +49,6 @@ class DeviceController {
       const base::WeakPtr<DeviceController>& device_controller_ptr,
       scoped_ptr<DeviceListener> device_listener);
 
-  base::WeakPtrFactory<DeviceController> weak_ptr_factory_;
   const scoped_ptr<Socket> host_socket_;
   // Used to notify the controller to exit.
   const int exit_notifier_fd_;
@@ -58,6 +57,8 @@ class DeviceController {
   const scoped_refptr<base::SingleThreadTaskRunner> construction_task_runner_;
   ListenersMap listeners_;
 
+  base::WeakPtrFactory<DeviceController> weak_ptr_factory_;

[digit1, 2014/09/09 14:50:00]

lgtm, but you probably want to add a comment here explaining this must be kept
as the last member, to avoid the problem resurfacing later :)

+
   DISALLOW_COPY_AND_ASSIGN(DeviceController);
 };