Web Animations: Add tests for player state transitions and fix discovered issues

Source/core/animation/AnimationPlayerTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 266 matching lines @@
     EXPECT_EQ(AnimationPlayer::Finished, player->playStateInternal());
     EXPECT_TRUE(player->finished());
 }
 
 TEST_F(AnimationAnimationPlayerTest, StartTimePauseFinish)
 {
     player->pause();
     EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->startTime()));
     player->finish(exceptionState);
-    EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
+    EXPECT_EQ(AnimationPlayer::Paused, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->startTime()));
 }
 
 TEST_F(AnimationAnimationPlayerTest, PauseBeatsFinish)
 {
     player->pause();
     EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
     simulateFrame(10);
     EXPECT_EQ(AnimationPlayer::Paused, player->playStateInternal());
     player->finish(exceptionState);
     EXPECT_EQ(AnimationPlayer::Paused, player->playStateInternal());
 }
 
 TEST_F(AnimationAnimationPlayerTest, StartTimeFinishPause)
 {
-    double startTime = player->startTime();
     player->finish(exceptionState);
-    EXPECT_EQ(startTime, player->startTime());
+    EXPECT_EQ(-30 * 1000, player->startTime());
     player->pause();
     EXPECT_TRUE(std::isnan(player->startTime()));
 }
 
 TEST_F(AnimationAnimationPlayerTest, StartTimeWithZeroPlaybackRate)
 {
     player->setPlaybackRate(0);
     EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->startTime()));
     simulateFrame(10);
@@ skipping 138 matching lines @@
     EXPECT_EQ(0, player->currentTimeInternal());
 }
 
 TEST_F(AnimationAnimationPlayerTest, ReverseSeeksToEnd)
 {
     player->setCurrentTimeInternal(40);
     player->reverse();
     EXPECT_EQ(30, player->currentTimeInternal());
 }
 
-TEST_F(AnimationAnimationPlayerTest, ReverseLimitsAnimationPlayer)
+TEST_F(AnimationAnimationPlayerTest, ReverseBeyondLimit)
 {
     player->setCurrentTimeInternal(40);
     player->setPlaybackRate(-1);
     player->reverse();
-    EXPECT_TRUE(player->finished());
-    EXPECT_EQ(40, player->currentTimeInternal());
+    EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
+    EXPECT_EQ(0, player->currentTimeInternal());
 
     player->setCurrentTimeInternal(-10);
     player->reverse();
-    EXPECT_TRUE(player->finished());
-    EXPECT_EQ(-10, player->currentTimeInternal());
+    EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
+    EXPECT_EQ(30, player->currentTimeInternal());
 }
 
 
 TEST_F(AnimationAnimationPlayerTest, Finish)
 {
     player->finish(exceptionState);
     EXPECT_EQ(30, player->currentTimeInternal());
     EXPECT_TRUE(player->finished());
 
     player->setPlaybackRate(-1);
@@ skipping 356 matching lines @@
     player->play();
     EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
     EXPECT_EQ(30 * 1000, player->currentTime());
     EXPECT_TRUE(std::isnan(player->startTime()));
     simulateFrame(10);
     EXPECT_EQ(AnimationPlayer::Running, player->playStateInternal());
     EXPECT_EQ(30 * 1000, player->currentTime());
     EXPECT_EQ(40 * 1000, player->startTime());
 }
 
-// FIXME: crbug.com/410229, when fixed, will reuqire the expected results of
-// this test to change (currentTime -> 30 * 1000).
 TEST_F(AnimationAnimationPlayerTest, ReverseAfterCancel)
 {
     player->cancel();
     EXPECT_EQ(AnimationPlayer::Idle, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->currentTime()));
     EXPECT_TRUE(std::isnan(player->startTime()));
     player->reverse();
     EXPECT_EQ(AnimationPlayer::Pending, player->playStateInternal());
-    EXPECT_TRUE(std::isnan(player->currentTime()));
+    EXPECT_EQ(30 * 1000, player->currentTime());
     EXPECT_TRUE(std::isnan(player->startTime()));
     simulateFrame(10);
-    EXPECT_EQ(AnimationPlayer::Finished, player->playStateInternal());
-    EXPECT_EQ(0 * 1000, player->currentTime());
-    EXPECT_EQ(10 * 1000, player->startTime());
+    EXPECT_EQ(AnimationPlayer::Running, player->playStateInternal());
+    EXPECT_EQ(30 * 1000, player->currentTime());
+    EXPECT_EQ(40 * 1000, player->startTime());
 }
 
 TEST_F(AnimationAnimationPlayerTest, FinishAfterCancel)
 {
     player->cancel();
     EXPECT_EQ(AnimationPlayer::Idle, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->currentTime()));
     EXPECT_TRUE(std::isnan(player->startTime()));
     player->finish(exceptionState);
-    EXPECT_EQ(AnimationPlayer::Finished, player->playStateInternal());
-    EXPECT_EQ(30 * 1000, player->currentTime());
-    EXPECT_EQ(0, player->startTime());
+    EXPECT_TRUE(std::isnan(player->currentTime()));
+    EXPECT_TRUE(std::isnan(player->startTime()));
+    EXPECT_EQ(AnimationPlayer::Idle, player->playStateInternal());
 }
 
 TEST_F(AnimationAnimationPlayerTest, PauseAfterCancel)
 {
     player->cancel();
     EXPECT_EQ(AnimationPlayer::Idle, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->currentTime()));
     EXPECT_TRUE(std::isnan(player->startTime()));
     player->pause();
     EXPECT_EQ(AnimationPlayer::Idle, player->playStateInternal());
     EXPECT_TRUE(std::isnan(player->currentTime()));
     EXPECT_TRUE(std::isnan(player->startTime()));
 }
 
 }