net/quic/quic_protocol.h - Issue 554993002: Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_protocol.h

Issue 554993002: Fix a crash bug in QuicUnackedPacketMap when truncated acks arrived. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@send_an_ack_74741188

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_protocol.h

diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h

index 888b4101db0599f2dd37cca69614ffe9a3b982d5..a935a85da2de3e7695559e6207ea4d80db01f44d 100644

--- a/net/quic/quic_protocol.h

+++ b/net/quic/quic_protocol.h

@@ -1071,7 +1071,7 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {

// Reason why this packet was transmitted.

TransmissionType transmission_type;

// Stores the sequence numbers of all transmissions of this packet.

- // Can never be null.

+ // Must always be NULL or have multiple elements.

SequenceNumberList* all_transmissions;

// In flight packets have not been abandoned or lost.

bool in_flight;

« no previous file with comments | « no previous file | net/quic/quic_unacked_packet_map.cc » ('j') | no next file with comments »