Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: cc/scheduler/scheduler_unittest.cc

Issue 554973002: Disable scheduler deadline task on battery power in Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added better tests for mithro Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/scheduler/scheduler_unittest.cc
diff --git a/cc/scheduler/scheduler_unittest.cc b/cc/scheduler/scheduler_unittest.cc
index 9c459b5b0be6286cc7dc4fe017aaf08f32e5a7b2..c9e3ba9f53cc3480c77024593ddd42f6528866df 100644
--- a/cc/scheduler/scheduler_unittest.cc
+++ b/cc/scheduler/scheduler_unittest.cc
@@ -10,6 +10,8 @@
#include "base/logging.h"
#include "base/memory/scoped_vector.h"
#include "base/message_loop/message_loop.h"
+#include "base/power_monitor/power_monitor.h"
+#include "base/power_monitor/power_monitor_source.h"
#include "base/run_loop.h"
#include "base/time/time.h"
#include "cc/test/begin_frame_args_test.h"
@@ -1969,5 +1971,172 @@ TEST(SchedulerTest, ScheduledActionActivateAfterBecomingInvisible) {
EXPECT_ACTION("ScheduledActionActivateSyncTree", client, 1, 2);
}
+class FakePowerMonitorSource : public base::PowerMonitorSource {
+ public:
+ FakePowerMonitorSource() {}
+ virtual ~FakePowerMonitorSource() {}
+ void GeneratePowerStateEvent(bool on_battery_power) {
+ on_battery_power_impl_ = on_battery_power;
+ ProcessPowerEvent(POWER_STATE_EVENT);
+ base::MessageLoop::current()->RunUntilIdle();
+ }
+ virtual bool IsOnBatteryPowerImpl() override {
+ return on_battery_power_impl_;
+ }
+
+ private:
+ bool on_battery_power_impl_;
+};
+
+TEST(SchedulerTest, SchedulerPowerMonitoring) {
+ FakePowerMonitorSource* power_monitor_source = new FakePowerMonitorSource;
+ base::PowerMonitor power_monitor(
+ (scoped_ptr<base::PowerMonitorSource>(power_monitor_source)));
+
+ FakeSchedulerClient client;
+ SchedulerSettings settings;
+ settings.prioritize_impl_latency_on_battery = true;
+ TestScheduler* scheduler = client.CreateScheduler(settings);
+
+ base::TimeTicks before_deadline, after_deadline;
+
+ scheduler->SetCanStart();
+ scheduler->SetVisible(true);
+ scheduler->SetCanDraw(true);
+
+ InitializeOutputSurfaceAndFirstCommit(scheduler, &client);
+
+ scheduler->SetNeedsCommit();
+ client.Reset();
+
+ // On non-battery power
+ EXPECT_FALSE(power_monitor.IsOnBatteryPower());
+
+ client.AdvanceFrame();
+ client.Reset();
+
+ before_deadline = client.now_src()->Now();
+ EXPECT_TRUE(client.task_runner().RunTasksWhile(
+ client.ImplFrameDeadlinePending(true)));
+ after_deadline = client.now_src()->Now();
+
+ // We post a non-zero deadline task when not on battery
+ EXPECT_LT(before_deadline, after_deadline);
+
+ // Switch to battery power
+ power_monitor_source->GeneratePowerStateEvent(true);
+ EXPECT_TRUE(power_monitor.IsOnBatteryPower());
+
+ client.AdvanceFrame();
+ client.Reset();
+
+ before_deadline = client.now_src()->Now();
+ EXPECT_TRUE(client.task_runner().RunTasksWhile(
+ client.ImplFrameDeadlinePending(true)));
+ after_deadline = client.now_src()->Now();
+
+ // We post a zero deadline task when on battery
+ EXPECT_EQ(before_deadline, after_deadline);
+
+ // Switch to non-battery power
+ power_monitor_source->GeneratePowerStateEvent(false);
+ EXPECT_FALSE(power_monitor.IsOnBatteryPower());
+
+ client.AdvanceFrame();
+ client.Reset();
+
+ // Same as before
+ before_deadline = client.now_src()->Now();
+ EXPECT_TRUE(client.task_runner().RunTasksWhile(
+ client.ImplFrameDeadlinePending(true)));
+ after_deadline = client.now_src()->Now();
+}
+
+TEST(SchedulerTest,
+ SimulateWindowsLowResolutionTimerOnBattery_PrioritizeImplLatencyOff) {
+ FakePowerMonitorSource* power_monitor_source = new FakePowerMonitorSource;
+ base::PowerMonitor power_monitor(
+ (scoped_ptr<base::PowerMonitorSource>(power_monitor_source)));
+
+ FakeSchedulerClient client;
+ SchedulerSettings settings;
+ TestScheduler* scheduler = client.CreateScheduler(settings);
+
+ scheduler->SetCanStart();
+ scheduler->SetVisible(true);
+ scheduler->SetCanDraw(true);
+
+ InitializeOutputSurfaceAndFirstCommit(scheduler, &client);
+
+ // Set needs commit so that the scheduler tries to wait for the main thread
+ scheduler->SetNeedsCommit();
+ // Set needs redraw so that the scheduler doesn't wait too long
+ scheduler->SetNeedsRedraw();
+ client.Reset();
+
+ // Switch to battery power
+ power_monitor_source->GeneratePowerStateEvent(true);
+ EXPECT_TRUE(power_monitor.IsOnBatteryPower());
+
+ client.AdvanceFrame();
+ client.Reset();
+
+ // Disable auto-advancing of now_src
+ client.task_runner().SetAutoAdvanceNowToPendingTasks(false);
+
+ // Deadline task is pending
+ EXPECT_TRUE(scheduler->BeginImplFrameDeadlinePending());
+ client.task_runner().RunPendingTasks();
+ // Deadline task is still pending
+ EXPECT_TRUE(scheduler->BeginImplFrameDeadlinePending());
+
+ // Advance now by 15 ms - same as windows low res timer
+ client.now_src()->AdvanceNowMicroseconds(15000);
+ EXPECT_TRUE(scheduler->BeginImplFrameDeadlinePending());
+ client.task_runner().RunUntilTime(client.now_src()->Now());
+ // Deadline task finally completes
+ EXPECT_FALSE(scheduler->BeginImplFrameDeadlinePending());
+}
+
+TEST(SchedulerTest,
+ SimulateWindowsLowResolutionTimerOnBattery_PrioritizeImplLatencyOn) {
+ FakePowerMonitorSource* power_monitor_source = new FakePowerMonitorSource;
+ base::PowerMonitor power_monitor(
+ (scoped_ptr<base::PowerMonitorSource>(power_monitor_source)));
+
+ FakeSchedulerClient client;
+ SchedulerSettings settings;
+ settings.prioritize_impl_latency_on_battery = true;
+ TestScheduler* scheduler = client.CreateScheduler(settings);
+
+ scheduler->SetCanStart();
+ scheduler->SetVisible(true);
+ scheduler->SetCanDraw(true);
+
+ InitializeOutputSurfaceAndFirstCommit(scheduler, &client);
+
+ // Set needs commit so that the scheduler tries to wait for the main thread
+ scheduler->SetNeedsCommit();
+ // Set needs redraw so that the scheduler doesn't wait too long
+ scheduler->SetNeedsRedraw();
+ client.Reset();
+
+ // Switch to battery power
+ power_monitor_source->GeneratePowerStateEvent(true);
+ EXPECT_TRUE(power_monitor.IsOnBatteryPower());
+
+ client.AdvanceFrame();
+ client.Reset();
+
+ // Disable auto-advancing of now_src
+ client.task_runner().SetAutoAdvanceNowToPendingTasks(false);
+
+ // Deadline task is pending
+ EXPECT_TRUE(scheduler->BeginImplFrameDeadlinePending());
+ client.task_runner().RunPendingTasks();
+ // Deadline task runs immediately
+ EXPECT_FALSE(scheduler->BeginImplFrameDeadlinePending());
+}
+
} // namespace
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698