Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6979)

Unified Diff: extensions/browser/extensions_test.h

Issue 554963002: Move extensions power API unit test to extensions_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api_test_utils.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extensions_test.h
diff --git a/extensions/browser/extensions_test.h b/extensions/browser/extensions_test.h
index a8ab790cf122c5f69ec25f3a928d7f3ce460c2b8..260a168d981ae2a999b9747cd01ad62bcac598cb 100644
--- a/extensions/browser/extensions_test.h
+++ b/extensions/browser/extensions_test.h
@@ -11,9 +11,9 @@
#include "testing/gtest/include/gtest/gtest.h"
namespace content {
+class BrowserContext;
class ContentClient;
class ContentBrowserClient;
-class TestBrowserContext;
}
namespace extensions {
@@ -32,9 +32,12 @@ class ExtensionsTest : public testing::Test {
ExtensionsTest();
virtual ~ExtensionsTest();
- content::TestBrowserContext* browser_context() {
- return browser_context_.get();
- }
+ // Returned as a BrowserContext since most users don't need methods from
James Cook 2014/09/09 00:05:39 I've found as I moved tests around that I frequent
Yoyo Zhou 2014/09/09 00:43:40 vs. extensions_browser_client, you mean? Yes, I ag
+ // TestBrowserContext.
+ content::BrowserContext* browser_context() { return browser_context_.get(); }
+
+ // Returned as a TestExtensionsBrowserClient since most users need to call
+ // test-specific methods on it.
TestExtensionsBrowserClient* extensions_browser_client() {
return extensions_browser_client_.get();
}
@@ -46,7 +49,7 @@ class ExtensionsTest : public testing::Test {
private:
scoped_ptr<content::ContentClient> content_client_;
scoped_ptr<content::ContentBrowserClient> content_browser_client_;
- scoped_ptr<content::TestBrowserContext> browser_context_;
+ scoped_ptr<content::BrowserContext> browser_context_;
scoped_ptr<TestExtensionsBrowserClient> extensions_browser_client_;
DISALLOW_COPY_AND_ASSIGN(ExtensionsTest);
« no previous file with comments | « extensions/browser/api_test_utils.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698