Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 554963002: Move extensions power API unit test to extensions_unittests (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Daniel Erat
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move extensions power API unit test to extensions_unittests It was running in Chrome's unit_tests suite for historical reasons. BUG=397164 TEST=extensions_unittests Committed: https://crrev.com/30a1ccd6ccf055b61ae86d29657f16513254b773 Cr-Commit-Position: refs/heads/master@{#293946}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -44 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 8 chunks +29 lines, -38 lines 0 comments Download
M extensions/browser/api_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/api_test_utils.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/browser/extensions_test.h View 3 chunks +8 lines, -5 lines 2 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
yoz, PTAL derat, just FYI https://codereview.chromium.org/554963002/diff/1/extensions/browser/extensions_test.h File extensions/browser/extensions_test.h (right): https://codereview.chromium.org/554963002/diff/1/extensions/browser/extensions_test.h#newcode35 extensions/browser/extensions_test.h:35: // Returned as a ...
6 years, 3 months ago (2014-09-09 00:05:40 UTC) #2
Yoyo Zhou
LGTM https://codereview.chromium.org/554963002/diff/1/extensions/browser/extensions_test.h File extensions/browser/extensions_test.h (right): https://codereview.chromium.org/554963002/diff/1/extensions/browser/extensions_test.h#newcode35 extensions/browser/extensions_test.h:35: // Returned as a BrowserContext since most users ...
6 years, 3 months ago (2014-09-09 00:43:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/554963002/1
6 years, 3 months ago (2014-09-09 15:25:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b48541746b36366d089cea37401ffcc22ee96a58
6 years, 3 months ago (2014-09-09 16:07:42 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30a1ccd6ccf055b61ae86d29657f16513254b773
Cr-Commit-Position: refs/heads/master@{#293946}

Powered by Google App Engine
This is Rietveld 408576698