Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 554943002: Update the alias mapping for Noto Sans CJK. (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
bungeman-skia
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update the alias mapping for Noto Sans CJK. To make the family names 'future-proof', we decided to shorten the name of Noto Sans CJK, which requires a change in the alias table in Skia. Chrome OS CL (actually updating the fonts) and Chrome CL (updating the font preferences on CrOS) are going together with this CL. BUG=412151 TEST=With the above two CLs in on Chrome OS, Noto Sans CJK {JP, SC} are used when MS P Gothic / Simhei are asked for by a web page. Committed: https://skia.googlesource.com/skia/+/7476cf533be14b84e83de1bf30db7eef889c1f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ports/SkFontConfigInterface_direct.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jungshik at Google
Sorry that we had to change the names and need to do this silly thing ...
6 years, 3 months ago (2014-09-09 18:54:43 UTC) #2
bungeman-skia
lgtm
6 years, 3 months ago (2014-09-09 19:16:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jshin@chromium.org/554943002/1
6 years, 3 months ago (2014-09-09 19:16:45 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 19:31:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 7476cf533be14b84e83de1bf30db7eef889c1f23

Powered by Google App Engine
This is Rietveld 408576698