Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 554933003: Make textInputFlags use static AtomicStrings (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
adamk, abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make textInputFlags use static AtomicStrings This method is called a lot during browser launch. Instead of reconstructing the same AtomicString every time (without even ConstructFromLiteral) pass in a local static AtomicString. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-12 15:18:12 UTC) #2
adamk
lgtm
6 years, 3 months ago (2014-09-12 15:23:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554933003/1
6 years, 3 months ago (2014-09-12 15:31:54 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 16:39:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181916

Powered by Google App Engine
This is Rietveld 408576698