Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 554913004: don't build IpcNetworkManager unit tests in non-webrtc builds (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

don't build IpcNetworkManager unit tests in non-webrtc builds Followup to CL 565773003, ipc_network_manager_unittest.cc seems to be webrtc-specific, so it shouldn't be built when webrtc is disabled. Committed: https://crrev.com/47565bb702a13947acb5115be1f8ed5d4357a216 Cr-Commit-Position: refs/heads/master@{#295356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Mostyn Bramley-Moore
@guoweis1, Sergey: please take a look at this small fixup.
6 years, 3 months ago (2014-09-17 12:47:54 UTC) #2
guoweis2
On 2014/09/17 12:47:54, Mostyn Bramley-Moore wrote: > @guoweis1, Sergey: please take a look at this ...
6 years, 3 months ago (2014-09-17 16:41:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554913004/1
6 years, 3 months ago (2014-09-17 20:09:56 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-17 20:09:58 UTC) #7
Mostyn Bramley-Moore
@brettw: can you please give this an OWNERS thumbs-up?
6 years, 3 months ago (2014-09-17 20:26:48 UTC) #9
brettw
lgtm
6 years, 3 months ago (2014-09-17 20:50:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554913004/1
6 years, 3 months ago (2014-09-17 20:55:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4aade64eac049dc7d421f62b37fd5c758c38a57f
6 years, 3 months ago (2014-09-17 21:57:57 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/47565bb702a13947acb5115be1f8ed5d4357a216 Cr-Commit-Position: refs/heads/master@{#295356}
6 years, 3 months ago (2014-09-17 21:58:32 UTC) #14
Sergey Ulanov
6 years, 3 months ago (2014-09-17 22:19:00 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698