Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 554833003: Add a manual test of the speed of parsing a giant alerts file. (Closed)

Created:
6 years, 3 months ago by Jeffrey Yasskin
Modified:
6 years, 3 months ago
Reviewers:
ojan
CC:
blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add a manual test of the speed of parsing a giant alerts file. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181585

Patch Set 1 #

Patch Set 2 : Handle exceptions and update to include trooper alerts. #

Total comments: 1

Patch Set 3 : Make sure the input JSON isn't modified by the update() algorithm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
A Tools/GardeningServer/model/test/manual/ct-failures-perf.html View 1 2 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jeffrey Yasskin
I'll have to `git cl land` this manually because the big-alerts.json file is too big.
6 years, 3 months ago (2014-09-08 20:51:09 UTC) #2
ojan
lgtm
6 years, 3 months ago (2014-09-08 22:29:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/554833003/1
6 years, 3 months ago (2014-09-08 22:30:07 UTC) #5
Jeffrey Yasskin
https://codereview.chromium.org/554833003/diff/10001/Tools/GardeningServer/model/test/manual/ct-failures-perf.html File Tools/GardeningServer/model/test/manual/ct-failures-perf.html (right): https://codereview.chromium.org/554833003/diff/10001/Tools/GardeningServer/model/test/manual/ct-failures-perf.html#newcode62 Tools/GardeningServer/model/test/manual/ct-failures-perf.html:62: iteration().then(loop, function(e) { console.error(e, e.stack); }); Now with more ...
6 years, 3 months ago (2014-09-08 22:43:52 UTC) #7
ojan
6 years, 3 months ago (2014-09-08 23:45:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as 181585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698