Log command name with GPU parse errors.

gpu/command_buffer/service/cmd_parser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains the implementation of the command parser.
 
 #include "gpu/command_buffer/service/cmd_parser.h"
 
 #include "base/logging.h"
 #include "base/debug/trace_event.h"
@@ skipping 33 matching lines @@
 // conditions). This function only validates the header, leaving the arguments
 // validation to the handler, so it can pass a reference to them.
 // - get_ is modified *after* the command has been executed.
 error::Error CommandParser::ProcessCommand() {
   CommandBufferOffset get = get_;
   if (get == put_)
     return error::kNoError;
 
   CommandHeader header = buffer_[get].value_header;
   if (header.size == 0) {
-    DVLOG(1) << "Error: zero sized command in command buffer";
+    LOG(ERROR) << "Parse error: zero sized command in command buffer";
     return error::kInvalidSize;
   }
 
   if (static_cast<int>(header.size) + get > entry_count_) {
-    DVLOG(1) << "Error: get offset out of bounds";
+    LOG(ERROR) << "Parse error: get offset out of bounds";
     return error::kOutOfBounds;
   }
 
   TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cb_command"),
                handler_->GetCommandName(header.command));
 
   error::Error result = handler_->DoCommand(
       header.command, header.size - 1, buffer_ + get);
 
-  // TODO(gman): If you want to log errors this is the best place to catch them.
-  //     It seems like we need an official way to turn on a debug mode and
-  //     get these errors.
   if (error::IsError(result)) {
     ReportError(header.command, result);
   }
 
   // If get was not set somewhere else advance it.
   if (get == get_ && result != error::kDeferCommandUntilLater)
     get_ = (get + header.size) % entry_count_;
 
   return result;
 }
 
 void CommandParser::ReportError(unsigned int command_id,
                                 error::Error result) {
-  DVLOG(1) << "Error: " << result << " for Command "
-           << handler_->GetCommandName(command_id);
+  LOG(ERROR) << "Error: " << result << " for Command "
+             << handler_->GetCommandName(command_id);
 }
 
 // Processes all the commands, while the buffer is not empty. Stop if an error
 // is encountered.
 error::Error CommandParser::ProcessAllCommands() {
   while (!IsEmpty()) {
     error::Error error = ProcessCommand();
     if (error)
       return error;
   }
   return error::kNoError;
 }
 
 }  // namespace gpu