BrowserPlugin: Remove BrowserPluginGuest::ToGuestRect

BrowserPlugin: Remove BrowserPluginGuest::ToGuestRect

BrowserPluginGuest::GetScreenCoordinates and BrowserPluginGuest::ToGuestRect
served very similar purposes, and having both around would probably just
increase the likelihood of bugs cropping up. This CL removes ToGuestRect.

BUG=none

Committed: https://crrev.com/940e498e0aed4f8881cf83b894754bbdd420f374
Cr-Commit-Position: refs/heads/master@{#293867}

[Fady Samuel, 2014-09-08 18:24:46]

fsamuel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Fady Samuel, 2014-09-08 18:31:12]

+nasko@: Please review RenderWidgetHostViewGuest.

[lazyboy, 2014-09-08 19:00:57]

LGTM with one nit.

https://codereview.chromium.org/554773002/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/554773002/diff/20001/content/browser/frame_ho...
content/browser/frame_host/render_widget_host_view_guest.cc:131: gfx::Rect
shifted_rect;
Would be easier to read by constructing the Rect directly from origin and size.
return gfx::Rect(guest_->GetScreenCoordinates(..), size_);

You can do this in ImeCompositionRangeChanged() change as well.

[Fady Samuel, 2014-09-08 19:17:04]

fsamuel@chromium.org changed reviewers:
+ nasko@chromium.org

[Fady Samuel, 2014-09-08 19:17:05]

oops, looks like I forgot to add Nasko last time.

+nasko@: Please review RenderWidgetHostViewGuest. Thanks!

https://codereview.chromium.org/554773002/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/554773002/diff/20001/content/browser/frame_ho...
content/browser/frame_host/render_widget_host_view_guest.cc:131: gfx::Rect
shifted_rect;
On 2014/09/08 19:00:57, lazyboy wrote:
> Would be easier to read by constructing the Rect directly from origin and
size.
> return gfx::Rect(guest_->GetScreenCoordinates(..), size_);
> 
> You can do this in ImeCompositionRangeChanged() change as well.

Done.

[nasko, 2014-09-08 23:04:40]

LGTM

[Fady Samuel, 2014-09-08 23:20:17]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2014-09-08 23:21:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fsamuel@chromium.org/554773002/80001

[commit-bot: I haz the power, 2014-09-09 06:18:35]

Committed patchset #5 (id:80001) as 19321040c13729a5e0fba3bef8e1fadf46086a9f

[commit-bot: I haz the power, 2014-09-10 03:50:58]

Patchset 5 (id:??) landed as
https://crrev.com/940e498e0aed4f8881cf83b894754bbdd420f374
Cr-Commit-Position: refs/heads/master@{#293867}