Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 554743009: remove main_render_frame(), use GetMainRenderFrame() instead (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove main_render_frame(), use GetMainRenderFrame() instead CL 93333002 added a main_render_frame() method to RenderFrameImpl, then about a week later CL 107893003 added a virtual GetMainRenderFrame() method with the same implementation. To avoid confusion, we could just use the latter and remove main_render_frame(). BUG=304341 Committed: https://crrev.com/c3335323f09a566cb6a78f424dd7c52966e13b31 Cr-Commit-Position: refs/heads/master@{#294562}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M content/public/test/render_view_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/external_popup_menu_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/history_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/history_entry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@jam: does this simplification look OK to you?
6 years, 3 months ago (2014-09-09 17:49:08 UTC) #2
jam
lgtm, thank you
6 years, 3 months ago (2014-09-12 04:06:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554743009/20001
6 years, 3 months ago (2014-09-12 07:39:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/14896)
6 years, 3 months ago (2014-09-12 08:10:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554743009/20001
6 years, 3 months ago (2014-09-12 09:04:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 073ff5d0e8daf752e1bb2d5dbf68fbb132ddee80
6 years, 3 months ago (2014-09-12 09:40:40 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 09:43:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3335323f09a566cb6a78f424dd7c52966e13b31
Cr-Commit-Position: refs/heads/master@{#294562}

Powered by Google App Engine
This is Rietveld 408576698