Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 554743007: SkRasterClip::quickReject doesn't need to check for emptiness as SkIRect::Intersect already does th… (Closed)

Created:
6 years, 3 months ago by gw280
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkRasterClip::quickReject doesn't need to check for emptiness as SkIRect::Intersect already does that for us R=reed1 BUG=skia: Committed: https://skia.googlesource.com/skia/+/49e3199e638595d7e8b8bf41081eb9cac5daaa2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/core/SkRasterClip.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
gw280
6 years, 3 months ago (2014-09-09 02:33:46 UTC) #1
reed1
lgtm
6 years, 3 months ago (2014-09-09 13:06:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/554743007/1
6 years, 3 months ago (2014-09-09 13:07:29 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 13:15:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 49e3199e638595d7e8b8bf41081eb9cac5daaa2d

Powered by Google App Engine
This is Rietveld 408576698