Browser Plugin: Move input to RWHVGuest to support interstitial pages

content/browser/browser_plugin/browser_plugin_guest.h

Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 6ee9f50f52683225066db63625eb1c7101a1f5e8..53313d305e2e8b23fb5060edcd71a63148a1cd6a 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -25,6 +25,7 @@
 #include "base/memory/linked_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
+#include "content/browser/web_contents/web_contents_impl.h"

[lazyboy, 2014/09/08 20:30:49]

Why is this required here?

[Fady Samuel, 2014/09/08 20:46:23]

To convert "embedder_web_contents_" to a WebContents from a WebContentsImpl.

we are not allowed to access a WebContentsImpl from RWHVGuest.

[lazyboy, 2014/09/08 20:53:19]

I'd move embedder_web_contents() to browser_plugin_guest.cc then.
It's not so obvious there's a cast involved and embedder_web_contents() is not a
simple getter.

[Fady Samuel, 2014/09/09 14:58:17]

Technically I should also be renaming this to GetEmbedderWebContents to indicate
this is a non-trivial accessor. However, that requires my updating multiple
callsites with many OWNERS. Could I do that in a separate cleanup CL?

[lazyboy, 2014/09/09 15:24:04]

Sure, I'd put a todo here then.

 #include "content/common/edit_command.h"
 #include "content/common/input/input_event_ack_state.h"
 #include "content/public/browser/browser_plugin_guest_delegate.h"
@@ -127,7 +128,7 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
 
   bool OnMessageReceivedFromEmbedder(const IPC::Message& message);
 
-  WebContentsImpl* embedder_web_contents() const {
+  WebContents* embedder_web_contents() const {
     return embedder_web_contents_;
   }
 
@@ -245,9 +246,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
       int instance_id,
       const FrameHostMsg_ReclaimCompositorResources_Params& params);
 
-  void OnHandleInputEvent(int instance_id,
-                                  const gfx::Rect& guest_window_rect,
-                                  const blink::WebInputEvent* event);
   void OnLockMouse(bool user_gesture,
                    bool last_unlocked_by_target,
                    bool privileged);