Browser Plugin: Move input to RWHVGuest to support interstitial pages

content/browser/browser_plugin/browser_plugin_guest.h

Index: content/browser/browser_plugin/browser_plugin_guest.h
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 6ee9f50f52683225066db63625eb1c7101a1f5e8..85e425baae9dc9e604b873455527b22ef9f27a18 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -25,6 +25,7 @@
 #include "base/memory/linked_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
+#include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/edit_command.h"
 #include "content/common/input/input_event_ack_state.h"
 #include "content/public/browser/browser_plugin_guest_delegate.h"
@@ -127,7 +128,10 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
 
   bool OnMessageReceivedFromEmbedder(const IPC::Message& message);
 
-  WebContentsImpl* embedder_web_contents() const {
+  // TODO(fsamuel): This is a non-trivial accessor because it converts a

[Charlie Reis, 2014/09/09 21:22:14]

I guess I'm missing the relevant detail-- how does the conversion make it
non-trivial?  Isn't that just an upcast?

If it is just an upcast, I also don't see why the change was needed.

[Charlie Reis, 2014/09/10 00:28:21]

One part of my question was about the TODO, which I don't think is necessary. 
It's still trivial and can remain inlined.
Thanks for the explanation, but let's avoid the change of return type if we can.
 One suggestion below.

[Fady Samuel, 2014/09/10 02:51:37]

Done.

[Fady Samuel, 2014/09/10 02:51:37]

Done.

+  // WebContentsImpl into a WebContents. We should rename this and move the
+  // implementation to the cc file.
+  WebContents* embedder_web_contents() const {
     return embedder_web_contents_;
   }
 
@@ -245,9 +249,6 @@ class CONTENT_EXPORT BrowserPluginGuest : public WebContentsObserver {
       int instance_id,
       const FrameHostMsg_ReclaimCompositorResources_Params& params);
 
-  void OnHandleInputEvent(int instance_id,
-                                  const gfx::Rect& guest_window_rect,
-                                  const blink::WebInputEvent* event);
   void OnLockMouse(bool user_gesture,
                    bool last_unlocked_by_target,
                    bool privileged);