Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 554723004: Removed cases that were taking too much power. Re-recorded html5 video and flash pages (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
tonyg, jeremy
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removed cases that were taking too much power. Re-recorded html5 video and flash pages BUG= Committed: https://crrev.com/7c1f4a98c359c092db8bef1bcfd93b3adf83b1c1 Cr-Commit-Position: refs/heads/master@{#293932}

Patch Set 1 #

Patch Set 2 : Added back in removed test cases, commented out. #

Patch Set 3 : fixed typo #

Patch Set 4 : Updated patch with .sha1 file #

Total comments: 1

Patch Set 5 : Removed old pagesets from JSON #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M tools/perf/page_sets/data/tough_energy_cases.json View 1 2 3 4 1 chunk +12 lines, -17 lines 0 comments Download
A tools/perf/page_sets/data/tough_energy_cases_004.wpr.sha1 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_energy_cases.py View 1 2 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 25 (8 generated)
sullivan
Dave, the presubmit script which is supposed to ask if I want to upload to ...
6 years, 3 months ago (2014-09-08 17:55:40 UTC) #2
jeremy
lgtm I'd support leaving these in the code with comments assuming these are cases we ...
6 years, 3 months ago (2014-09-08 18:00:59 UTC) #3
sullivan
On 2014/09/08 18:00:59, jeremy wrote: > lgtm > > I'd support leaving these in the ...
6 years, 3 months ago (2014-09-08 19:03:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/554723004/30003
6 years, 3 months ago (2014-09-08 19:09:02 UTC) #6
dtu
Wait, sorry, you need to check in the .sha1 file.
6 years, 3 months ago (2014-09-08 19:51:48 UTC) #8
sullivan
On 2014/09/08 19:51:48, dtu wrote: > Wait, sorry, you need to check in the .sha1 ...
6 years, 3 months ago (2014-09-08 20:02:15 UTC) #9
sullivan
On 2014/09/08 19:51:48, dtu wrote: > Wait, sorry, you need to check in the .sha1 ...
6 years, 3 months ago (2014-09-08 20:02:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/554723004/50001
6 years, 3 months ago (2014-09-08 20:04:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9436)
6 years, 3 months ago (2014-09-08 20:13:18 UTC) #14
sullivan
On 2014/09/08 20:13:18, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-08 20:14:12 UTC) #15
tonyg
https://codereview.chromium.org/554723004/diff/50001/tools/perf/page_sets/data/tough_energy_cases.json File tools/perf/page_sets/data/tough_energy_cases.json (right): https://codereview.chromium.org/554723004/diff/50001/tools/perf/page_sets/data/tough_energy_cases.json#newcode11 tools/perf/page_sets/data/tough_energy_cases.json:11: "tough_energy_cases_003.wpr": [ I think we have to have a ...
6 years, 3 months ago (2014-09-08 22:24:43 UTC) #16
tonyg
lgtm in advance to avoid a round trip
6 years, 3 months ago (2014-09-09 01:49:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/554723004/70001
6 years, 3 months ago (2014-09-09 01:57:55 UTC) #19
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-09 04:10:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sullivan@chromium.org/554723004/70001
6 years, 3 months ago (2014-09-09 13:19:51 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:70001) as fa6e68ae4841bd7d90b4f5fdca06b99434cc5189
6 years, 3 months ago (2014-09-09 13:23:53 UTC) #24
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:09 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7c1f4a98c359c092db8bef1bcfd93b3adf83b1c1
Cr-Commit-Position: refs/heads/master@{#293932}

Powered by Google App Engine
This is Rietveld 408576698