Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 554713002: Disable WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)
Modified:
6 years, 3 months ago
Reviewers:
keishi, reed
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint It broke on Android Tests (dbg) http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21342 [FAIL] org.chromium.content.browser.WebContentsObserverAndroidTest#testDidFirstVisuallyNonEmptyPaint: java.util.concurrent.TimeoutException: waitForCallback timed out! at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183) at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191) at org.chromium.content.browser.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:197) at org.chromium.content.browser.WebContentsObserverAndroidTest.testDidFirstVisuallyNonEmptyPaint(WebContentsObserverAndroidTest.java:70) at java.lang.reflect.Method.invokeNative(Native Method) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554) BUG=411931 TBR=keishi, reed Committed: https://chromium.googlesource.com/chromium/src/+/833089c8f5bec9a81323cbb314689f9569eb6ec8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Committed patchset #1 (id:1) manually as 833089c (presubmit successful).
6 years, 3 months ago (2014-09-08 16:24:20 UTC) #1
arv (Not doing code reviews)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/551043003/ by arv@chromium.org. ...
6 years, 3 months ago (2014-09-08 16:40:21 UTC) #2
Fabrice (no longer in Chrome)
On 2014/09/08 16:40:21, arv wrote: > A revert of this CL (patchset #1 id:1) has ...
6 years, 3 months ago (2014-09-08 16:52:24 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/833089c8f5bec9a81323cbb314689f9569eb6ec8
Cr-Commit-Position: refs/heads/master@{#293738}

Powered by Google App Engine
This is Rietveld 408576698