Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 554693004: Adds a didReceiveInputEvent api to the blink scheduler (Closed)

Created:
6 years, 3 months ago by alex clarke (OOO till 29th)
Modified:
6 years, 3 months ago
Reviewers:
alexclarke, Sami, eseidel
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Input tasks are not always routed by the main thread, but the blink scheduler still needs to know about them because we want it to enter low latency mode when the user is interacting with the device. To facilitate that this patch adds an didReceiveInputEvent API function. BUG=391005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181830

Patch Set 1 #

Patch Set 2 : Added some more tests #

Total comments: 2

Patch Set 3 : Rebased #

Patch Set 4 : Fixed an error #

Total comments: 2

Patch Set 5 : Added a TearDown #

Patch Set 6 : Fixed an assert issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -2 lines) Patch
M Source/platform/exported/WebSchedulerProxy.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/scheduler/Scheduler.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/scheduler/Scheduler.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/scheduler/SchedulerTest.cpp View 1 2 3 4 5 5 chunks +43 lines, -2 lines 0 comments Download
M public/platform/WebSchedulerProxy.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
alexclarke
6 years, 3 months ago (2014-09-10 15:08:03 UTC) #3
eseidel
lgtm So long as we're not taking that lock too often (couple times a frame ...
6 years, 3 months ago (2014-09-10 16:10:34 UTC) #4
Sami
lgtm. One question about the unit tests though. https://codereview.chromium.org/554693004/diff/60001/Source/platform/scheduler/SchedulerTest.cpp File Source/platform/scheduler/SchedulerTest.cpp (right): https://codereview.chromium.org/554693004/diff/60001/Source/platform/scheduler/SchedulerTest.cpp#newcode489 Source/platform/scheduler/SchedulerTest.cpp:489: m_scheduler->postCompositorTask(FROM_HERE, ...
6 years, 3 months ago (2014-09-11 15:12:05 UTC) #5
alexclarke
https://codereview.chromium.org/554693004/diff/20001/Source/platform/scheduler/Scheduler.cpp File Source/platform/scheduler/Scheduler.cpp (right): https://codereview.chromium.org/554693004/diff/20001/Source/platform/scheduler/Scheduler.cpp#newcode165 Source/platform/scheduler/Scheduler.cpp:165: void Scheduler::didReceiveInputEvent() On 2014/09/10 16:10:34, eseidel wrote: > How ...
6 years, 3 months ago (2014-09-11 15:21:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554693004/80001
6 years, 3 months ago (2014-09-11 15:22:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/24429)
6 years, 3 months ago (2014-09-11 15:39:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554693004/100001
6 years, 3 months ago (2014-09-11 15:51:14 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 16:54:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 181830

Powered by Google App Engine
This is Rietveld 408576698