Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 554683002: Add a script that can generate simple test cases for user-exposed JS builtins (Closed)

Created:
6 years, 3 months ago by Jakob Kummerow
Modified:
6 years, 3 months ago
Reviewers:
Martin Barbella
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add a script that can generate simple test cases for user-exposed JS builtins (we won't check in any such tests; they can be generated on the fly when needed) R=mbarbella@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23862

Patch Set 1 #

Patch Set 2 : use variables instead of literals #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -0 lines) Patch
A tools/detect-builtins.js View 1 chunk +51 lines, -0 lines 0 comments Download
A tools/generate-builtins-tests.py View 1 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Martin Barbella
LGTM with respect to the generated content. I didn't have time to review this carefully ...
6 years, 3 months ago (2014-09-09 15:21:15 UTC) #2
Jakob Kummerow
6 years, 3 months ago (2014-09-11 09:59:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698