Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4903)

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_component_installer.h

Issue 55463002: Remove PNaCl's RequestFirstInstall, use resource throttle instead (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reorder functions Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/pnacl/pnacl_component_installer.h
diff --git a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h
index 08488839a126e1647940e41c54b4e6d6d95527dc..0469a4985acc3c58c8da292810ba25502a15eede 100644
--- a/chrome/browser/component_updater/pnacl/pnacl_component_installer.h
+++ b/chrome/browser/component_updater/pnacl/pnacl_component_installer.h
@@ -14,7 +14,6 @@
#include "base/version.h"
#include "chrome/browser/component_updater/component_updater_service.h"
#include "chrome/browser/component_updater/pnacl/pnacl_profile_observer.h"
-#include "chrome/browser/component_updater/pnacl/pnacl_updater_observer.h"
class CommandLine;
@@ -75,22 +74,7 @@ class PnaclComponentInstaller : public ComponentInstaller {
ComponentUpdateService* cus() const { return cus_; }
- typedef base::Callback<void(bool)> InstallCallback;
-
- // Ask the component updater service to do a first-install for PNaCl.
- // The |installed| callback will be run with |true| on success,
- // or run with |false| on an error. The callback is called on the UI thread.
- void RequestFirstInstall(const InstallCallback& installed);
-
private:
- friend class PnaclUpdaterObserver;
-
- // Called when a RequestFirstInstall completed successfully.
- void NotifyInstallSuccess();
-
- // Called when a RequestFirstInstall will not happen, or an error occurred.
- void NotifyInstallError();
-
bool per_user_;
bool updates_disabled_;
scoped_ptr<PnaclProfileObserver> profile_observer_;
@@ -98,11 +82,6 @@ class PnaclComponentInstaller : public ComponentInstaller {
base::Version current_version_;
std::string current_fingerprint_;
ComponentUpdateService* cus_;
- // The one callback to call when there is a RequestFirstInstall.
- InstallCallback install_callback_;
- // Component updater service observer, to determine when an on-demand
- // install request failed.
- scoped_ptr<PnaclUpdaterObserver> updater_observer_;
DISALLOW_COPY_AND_ASSIGN(PnaclComponentInstaller);
};

Powered by Google App Engine
This is Rietveld 408576698