Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 554623002: Remove unused class ShellAppWindowController (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
James Cook, oshima
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused class ShellAppWindowController BUG=None Committed: https://crrev.com/b73e07836a96661fdf6d599d0f73f4486c603dcb Cr-Commit-Position: refs/heads/master@{#293920}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -105 lines) Patch
M athena/main/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D athena/main/athena_app_window_controller.h View 1 chunk +0 lines, -32 lines 0 comments Download
D athena/main/athena_app_window_controller.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D extensions/shell/browser/shell_app_window_controller.h View 1 chunk +0 lines, -33 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
hashimoto
6 years, 3 months ago (2014-09-08 09:47:58 UTC) #2
James Cook
lgtm
6 years, 3 months ago (2014-09-08 17:47:22 UTC) #3
oshima
lgtm
6 years, 3 months ago (2014-09-08 17:49:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/554623002/1
6 years, 3 months ago (2014-09-09 00:28:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/3184) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/3008) chromium_presubmit ...
6 years, 3 months ago (2014-09-09 06:35:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/554623002/20001
6 years, 3 months ago (2014-09-09 10:04:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as be05c742ecbb6bf0e85fc1676256215552076c36
6 years, 3 months ago (2014-09-09 11:17:40 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b73e07836a96661fdf6d599d0f73f4486c603dcb
Cr-Commit-Position: refs/heads/master@{#293920}

Powered by Google App Engine
This is Rietveld 408576698