Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 554613003: Fix logic in PerfProfiler.is_supported. (Closed)

Created:
6 years, 3 months ago by achuithb
Modified:
6 years, 3 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix logic in PerfProfiler.is_supported. The current logic doesn't work when we run the test locally on the DUT because the browser_type is 'system'. BUG=411280 TEST=testPerfProfiler skipped on the DUT. Committed: https://crrev.com/111ceb9e054cef9c71c37073c8b6d3858fc4cd4b Cr-Commit-Position: refs/heads/master@{#293833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
achuithb
Please review Toni
6 years, 3 months ago (2014-09-08 13:55:51 UTC) #2
tbarzic
On 2014/09/08 13:55:51, achuithb wrote: > Please review Toni lgtm
6 years, 3 months ago (2014-09-08 17:14:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/554613003/1
6 years, 3 months ago (2014-09-08 19:23:46 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 23:45:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/554613003/1
6 years, 3 months ago (2014-09-08 23:50:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as e1a1e9ea2e43d1e37cc6bb863deabc5b09346f07
6 years, 3 months ago (2014-09-09 01:48:10 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/111ceb9e054cef9c71c37073c8b6d3858fc4cd4b
Cr-Commit-Position: refs/heads/master@{#293833}

Powered by Google App Engine
This is Rietveld 408576698