Issue 554583004: Revert of nanobench: lazily decode bitmaps from SKPs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554583004: Revert of nanobench: lazily decode bitmaps from SKPs (Closed)

Created:
6 years, 3 months ago by mtklein

Modified:
6 years, 3 months ago

Reviewers:
robertphillips, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of nanobench: lazily decode bitmaps from SKPs (patchset #1 id:1 of https://codereview.chromium.org/572933006/) Reason for revert: skia:2944 Original issue's description: > nanobench: lazily decode bitmaps from SKPs > > This makes it considerably cheaper to run SKP recording benchmarks, without > affecting their measurements and without really affecting SKP playback > benchmarks at all. > > On my machine, running out/Release/nanobench --match skp --config nondrendering > drops in run time from 6.7s to 2.5s, and the peak RAM usage drops from 129M to 50M. > > I'm strongly considering making this lazy decoding the default. > > BUG=skia:2944 > > Committed: https://skia.googlesource.com/skia/+/d664c21a38de98d8db210c46f7a8c4187f1534da TBR=robertphillips@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:2944 Committed: https://skia.googlesource.com/skia/+/963504bd0a8ced7e1177ae136da03a9cc343d886

Created: 6 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -5 lines)			Patch
M	bench/nanobench.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	gyp/bench.gyp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gyp/iOSShell.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of nanobench: lazily decode bitmaps from SKPs

6 years, 3 months ago (2014-09-17 13:58:25 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554583004/1

6 years, 3 months ago (2014-09-17 13:58:34 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-17 13:58:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 963504bd0a8ced7e1177ae136da03a9cc343d886