content/browser/service_worker/service_worker_browsertest.cc - Issue 554573002: SWRegistration::unregister returns false when the registration is already unregistered. (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 554573002: SWRegistration::unregister returns false when the registration is already unregistered. (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move the conversion from SWStatusCode to boolean to browser-side Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index a1a26585aa8ce99a5889f486888716fdaddede49..a44cd7bc49659e742c1492b2a7c56e71487e2cab 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -882,12 +882,12 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBlackBoxBrowserTest, MAYBE_Registration) {

const std::string kWorkerUrl = "/service_worker/fetch_event.js";

- // Unregistering nothing should return true.

+ // Unregistering nothing should return false.

{

base::RunLoop run_loop;

public_context()->UnregisterServiceWorker(

embedded_test_server()->GetURL("/"),

- base::Bind(&ExpectResultAndRun, true, run_loop.QuitClosure()));

+ base::Bind(&ExpectResultAndRun, false, run_loop.QuitClosure()));

run_loop.Run();

}