content/common/service_worker/service_worker_messages.h - Issue 554573002: SWRegistration::unregister returns false when the registration is already unregistered. (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 554573002: SWRegistration::unregister returns false when the registration is already unregistered. (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/common/service_worker/service_worker_status_code.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index f940d06a48eabd2335a4da61eccb50f18f30ea70..f975c02f9a59fda13fec6d5caddf637987b364e3 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -31,6 +31,9 @@ IPC_ENUM_TRAITS_MAX_VALUE(blink::WebServiceWorkerEventResult,

IPC_ENUM_TRAITS_MAX_VALUE(blink::WebServiceWorkerState,

blink::WebServiceWorkerStateLast)

+IPC_ENUM_TRAITS_MAX_VALUE(content::ServiceWorkerStatusCode,

+ content::SERVICE_WORKER_STATUS_LAST)

IPC_STRUCT_TRAITS_BEGIN(content::ServiceWorkerFetchRequest)

IPC_STRUCT_TRAITS_MEMBER(url)

IPC_STRUCT_TRAITS_MEMBER(method)

@@ -192,9 +195,10 @@ IPC_MESSAGE_CONTROL4(ServiceWorkerMsg_ServiceWorkerRegistered,

content::ServiceWorkerVersionAttributes)

// Response to ServiceWorkerMsg_UnregisterServiceWorker.

-IPC_MESSAGE_CONTROL2(ServiceWorkerMsg_ServiceWorkerUnregistered,

+IPC_MESSAGE_CONTROL3(ServiceWorkerMsg_ServiceWorkerUnregistered,

int /* thread_id */,

- int /* request_id */)

+ int /* request_id */,

+ content::ServiceWorkerStatusCode)

horo 2014/09/09 01:24:15 We don't need to send the status code. What we nee

shimazu 2014/09/10 01:22:09 Done.

// Sent when any kind of registration error occurs during a

// RegisterServiceWorker handler above.